From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82D5CC433DB for ; Wed, 13 Jan 2021 13:46:24 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB9FC23339 for ; Wed, 13 Jan 2021 13:46:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB9FC23339 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 2F6B316B2; Wed, 13 Jan 2021 14:45:29 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 2F6B316B2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1610545579; bh=lFiSGuGkp+O25KePcr4PoRbTz26R2ZkZhnevWQ9mQAs=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=JujYWnfGhZuMBDtm4nKiKZASqdVfG6s6eW21HIc+v/IZcxVyBy4oestOEfeTzl3oT tRpaNOqsiPmtbK9W8kb5CbrxBXSmmSUxYaNoYza4edJzc1CtrlM1x3hV1KQxJV6zvp 85zx6uCGBCVe59fq6aHxndyo2jmu55uKrNwF0few= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id AD75EF8016D; Wed, 13 Jan 2021 14:45:28 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B040DF801ED; Wed, 13 Jan 2021 14:45:22 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 4E993F80113; Wed, 13 Jan 2021 14:45:13 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 4E993F80113 IronPort-SDR: 3oAywNYaCBhuUgnlu2jKADfI8gUJVMZo4KPACflm3ZdjT1n9oCzyBiBRxJ3sRhsylfoyXzbbmD OHF5ixnVN/LA== X-IronPort-AV: E=McAfee;i="6000,8403,9862"; a="157978339" X-IronPort-AV: E=Sophos;i="5.79,344,1602572400"; d="scan'208";a="157978339" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2021 05:45:07 -0800 IronPort-SDR: 1qWKctZF2aMVZS18S29sCKBJhbYed39QQoY8oDZZb/S2UNHZ21yAf22DNCaRRScgB2Lqksa3ek TscPkm4LX/vw== X-IronPort-AV: E=Sophos;i="5.79,344,1602572400"; d="scan'208";a="464905380" Received: from aslawinx-mobl.ger.corp.intel.com (HELO [10.249.140.37]) ([10.249.140.37]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2021 05:45:06 -0800 Subject: Re: [Sound-open-firmware] SoF support for 8086:9d71? To: Kai-Heng Feng References: <9I9CLQ.GP190FSJBRXK3@canonical.com> <47ec2533-584c-d7f3-4489-e3a043e658e1@linux.intel.com> <1afda15d-1ea7-3a8f-6dcc-37f747ff7bac@linux.intel.com> <5de3f7a5-273f-9d0a-2479-6b80b8da1b6a@linux.intel.com> From: =?UTF-8?Q?Amadeusz_S=c5=82awi=c5=84ski?= Message-ID: Date: Wed, 13 Jan 2021 14:44:54 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Cc: SOUND , Pierre-Louis Bossart , "moderated list:SOUND - SOUND OPEN FIRMWARE \(SOF\) DRIVERS" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 1/13/2021 5:48 AM, Kai-Heng Feng wrote: > On Tue, Jan 12, 2021 at 9:25 PM Amadeusz Sławiński > wrote: >> >> On 12/17/2020 9:25 AM, Kai-Heng Feng wrote: >> (...) >>>>> >>>>> Can you try this instead, the dependencies are indeed wrong in the Makefile: >>>> >>>> Ok, compiling a kernel for user to test... >>> >>> Well, this happens: >>> ERROR: modpost: "skl_dsp_set_dma_control" >>> [sound/soc/intel/skylake/snd-soc-skl-ssp-clk.ko] undefined! >>> make[1]: *** [scripts/Makefile.modpost:111: sound/Module.symvers] Error 1 >>> make[1]: *** Deleting file 'sound/Module.symvers' >>> make: *** [Makefile:1709: modules] Error 2 >>> >>> Kai-Heng >>> >>>> >>>> Kai-Heng >>>> >>>>> >>>>> diff --git a/sound/soc/intel/Makefile b/sound/soc/intel/Makefile >>>>> index 4e0248d2accc..7c5038803be7 100644 >>>>> --- a/sound/soc/intel/Makefile >>>>> +++ b/sound/soc/intel/Makefile >>>>> @@ -5,7 +5,7 @@ obj-$(CONFIG_SND_SOC) += common/ >>>>> # Platform Support >>>>> obj-$(CONFIG_SND_SST_ATOM_HIFI2_PLATFORM) += atom/ >>>>> obj-$(CONFIG_SND_SOC_INTEL_CATPT) += catpt/ >>>>> -obj-$(CONFIG_SND_SOC_INTEL_SKYLAKE) += skylake/ >>>>> +obj-$(CONFIG_SND_SOC_INTEL_SKYLAKE_COMMON) += skylake/ >>>>> obj-$(CONFIG_SND_SOC_INTEL_KEEMBAY) += keembay/ >>>>> >>>>> # Machine support >>>>> >>>>> >> >> Hi, >> >> what is the status of this issue? > > Still the same, unresolved. > >> Does it now work with usptream kernel? > > No it doesn't. > Can you try with following patch: diff --git a/sound/soc/intel/Makefile b/sound/soc/intel/Makefile index 4e0248d2accc..7c5038803be7 100644 --- a/sound/soc/intel/Makefile +++ b/sound/soc/intel/Makefile @@ -5,7 +5,7 @@ obj-$(CONFIG_SND_SOC) += common/ # Platform Support obj-$(CONFIG_SND_SST_ATOM_HIFI2_PLATFORM) += atom/ obj-$(CONFIG_SND_SOC_INTEL_CATPT) += catpt/ -obj-$(CONFIG_SND_SOC_INTEL_SKYLAKE) += skylake/ +obj-$(CONFIG_SND_SOC_INTEL_SKYLAKE_COMMON) += skylake/ obj-$(CONFIG_SND_SOC_INTEL_KEEMBAY) += keembay/ # Machine support diff --git a/sound/soc/intel/skylake/Makefile b/sound/soc/intel/skylake/Makefile index dd39149b89b1..1c4649bccec5 100644 --- a/sound/soc/intel/skylake/Makefile +++ b/sound/soc/intel/skylake/Makefile @@ -7,7 +7,7 @@ ifdef CONFIG_DEBUG_FS snd-soc-skl-objs += skl-debug.o endif -obj-$(CONFIG_SND_SOC_INTEL_SKYLAKE) += snd-soc-skl.o +obj-$(CONFIG_SND_SOC_INTEL_SKYLAKE_COMMON) += snd-soc-skl.o #Skylake Clock device support snd-soc-skl-ssp-clk-objs := skl-ssp-clk.o