From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEAB1C433DF for ; Tue, 7 Jul 2020 19:28:38 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 35EB020720 for ; Tue, 7 Jul 2020 19:28:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="LnV10psR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 35EB020720 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C829916B1; Tue, 7 Jul 2020 21:27:46 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C829916B1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1594150116; bh=3Dmo2V5uNXyJmKc6NbpGB1/B/HchRW7Q9e8SPJx+gdU=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=LnV10psRoXlXx3JAdqcLeNF0D6FFATOYaozzu9Km1jhOv8Dene+dbUY5NfvVS++bY Yxd7H946wrMmcfsFwm+abQCE25pE7azpGUuwuEDNcna0f54WP3zRDBpda70qZg/G2r KsSOA64QWcrdmGJ/6EPq8A00HDqvmfwVa4RoZlDk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C955BF800DF; Tue, 7 Jul 2020 21:26:56 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 24F06F80257; Tue, 7 Jul 2020 21:26:53 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 9AC73F801F9 for ; Tue, 7 Jul 2020 21:26:50 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 9AC73F801F9 IronPort-SDR: oQjZb8Ti++h9pZZFYnKGgGHR0ajIEGTonlQhMyfWtti7Yvict7qNZuWJqp9m5/eXpsKr/uiADm 4AOLXE2099XQ== X-IronPort-AV: E=McAfee;i="6000,8403,9675"; a="146751731" X-IronPort-AV: E=Sophos;i="5.75,324,1589266800"; d="scan'208";a="146751731" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2020 12:26:47 -0700 IronPort-SDR: 9li1rqbK/QdwedKg4BVTGrrBeOzWqQZc81aCjJ7zwNf7tqs0nv+wlUeHkqg+KbHwLekN8Ao+Zg MYQFvRCrCaEQ== X-IronPort-AV: E=Sophos;i="5.75,324,1589266800"; d="scan'208";a="297493435" Received: from mrtorger-mobl1.amr.corp.intel.com (HELO [10.254.77.62]) ([10.254.77.62]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2020 12:26:46 -0700 Subject: Re: [PATCH 06/11] ASoC: q6asm: add support to remove intial and trailing silence To: Srinivas Kandagatla , broonie@kernel.org References: <20200707163641.17113-1-srinivas.kandagatla@linaro.org> <20200707163641.17113-7-srinivas.kandagatla@linaro.org> From: Pierre-Louis Bossart Message-ID: Date: Tue, 7 Jul 2020 11:55:04 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200707163641.17113-7-srinivas.kandagatla@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: alsa-devel@alsa-project.org, ckeepax@opensource.cirrus.com, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, tiwai@suse.com, vkoul@kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" > +int q6asm_stream_remove_initial_silence(struct audio_client *ac, > + uint32_t stream_id, > + uint32_t initial_samples) > +{ > + return q6asm_stream_remove_silence(ac, stream_id, > + ASM_DATA_CMD_REMOVE_INITIAL_SILENCE, > + initial_samples); > +} > +EXPORT_SYMBOL_GPL(q6asm_stream_remove_initial_silence); > + > +int q6asm_stream_remove_trailing_silence(struct audio_client *ac, uint32_t stream_id, > + uint32_t trailing_samples) > +{ > + return q6asm_stream_remove_silence(ac, stream_id, > + ASM_DATA_CMD_REMOVE_TRAILING_SILENCE, > + trailing_samples); > +} > +EXPORT_SYMBOL_GPL(q6asm_stream_remove_trailing_silence); do you need those wrappers? Might as well call the _remove_silence() function with the right parameters, no?