alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>,
	Liam Girdwood <liam.r.girdwood@linux.intel.com>,
	Mark Brown <broonie@kernel.org>, Bard Liao <bardliao@realtek.com>,
	Oder Chiou <oder_chiou@realtek.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/2] ASoC: Intel: bytcr_rt5640: Add quirk for the Nuvison/TMax TM800W560 tablet
Date: Mon, 4 Jun 2018 08:57:58 -0500	[thread overview]
Message-ID: <ddb258d0-e8c4-fda7-f45f-fc396fc31acc@linux.intel.com> (raw)
In-Reply-To: <20180603134232.677-1-hdegoede@redhat.com>

On 6/3/18 8:42 AM, Hans de Goede wrote:
> Add a quirk for the Nuvison/TMax TM800W560 tablet, this tablet uses IN1
> for the internal mic rather then the default IN3 and it uses JD2 rather
> then JD1 for its not-inverted jack-detect switch.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Both
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

BTW maybe we should move those quirks to a separate file, the quirk 
definitions will become larger than actual code pretty soon ...

> ---
>   sound/soc/intel/boards/bytcr_rt5640.c | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
> 
> diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c
> index d675d550f6c1..27a05778584f 100644
> --- a/sound/soc/intel/boards/bytcr_rt5640.c
> +++ b/sound/soc/intel/boards/bytcr_rt5640.c
> @@ -549,6 +549,20 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
>   					BYT_RT5640_DIFF_MIC |
>   					BYT_RT5640_MCLK_EN),
>   	},
> +	{	/* Nuvison/TMax TM800W560 */
> +		.matches = {
> +			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "TMAX"),
> +			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "TM800W560L"),
> +		},
> +		.driver_data = (void *)(BYT_RT5640_IN1_MAP |
> +					BYT_RT5640_JD_SRC_JD2_IN4N |
> +					BYT_RT5640_OVCD_TH_2000UA |
> +					BYT_RT5640_OVCD_SF_0P75 |
> +					BYT_RT5640_JD_NOT_INV |
> +					BYT_RT5640_DIFF_MIC |
> +					BYT_RT5640_SSP0_AIF1 |
> +					BYT_RT5640_MCLK_EN),
> +	},
>   	{	/* Pipo W4 */
>   		.matches = {
>   			DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "AMI Corporation"),
> 

  parent reply	other threads:[~2018-06-04 13:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-03 13:42 [PATCH 1/2] ASoC: Intel: bytcr_rt5640: Add quirk for the Nuvison/TMax TM800W560 tablet Hans de Goede
2018-06-03 13:42 ` [PATCH 2/2] ASoC: Intel: bytcr_rt5640: Fix Acer Iconia 8 over-current detect threshold Hans de Goede
2018-06-18 12:06   ` Applied "ASoC: Intel: bytcr_rt5640: Fix Acer Iconia 8 over-current detect threshold" to the asoc tree Mark Brown
2018-06-04 13:57 ` Pierre-Louis Bossart [this message]
2018-06-04 14:00   ` [PATCH 1/2] ASoC: Intel: bytcr_rt5640: Add quirk for the Nuvison/TMax TM800W560 tablet Hans de Goede
2018-06-18 12:04     ` Mark Brown
2018-06-18 12:06 ` Applied "ASoC: Intel: bytcr_rt5640: Add quirk for the Nuvison/TMax TM800W560 tablet" to the asoc tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ddb258d0-e8c4-fda7-f45f-fc396fc31acc@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=bardliao@realtek.com \
    --cc=broonie@kernel.org \
    --cc=hdegoede@redhat.com \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=oder_chiou@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).