From: Arvind Yadav <arvind.yadav.cs@gmail.com>
To: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
tiwai@suse.com, matthias.bgg@gmail.com
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: [PATCH 4/5 v4] ASoC: intel: sst: Handle return value of platform_get_irq
Date: Wed, 29 Nov 2017 21:47:13 +0530 [thread overview]
Message-ID: <deb09b18d95f81661dbb8136fec947a548af6a77.1511970158.git.arvind.yadav.cs@gmail.com> (raw)
In-Reply-To: <4ce907b8389af30eb0677e70cf543a2b795cca12.1511970158.git.arvind.yadav.cs@gmail.com>
In-Reply-To: <4ce907b8389af30eb0677e70cf543a2b795cca12.1511970158.git.arvind.yadav.cs@gmail.com>
platform_get_irq() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
changes in v2 :
Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
changes in v3 :
Return -EIO insted of ctx->irq_num.
changes in v4 :
Add separate error for irq == 0 and irq < 0.
sound/soc/intel/atom/sst/sst_acpi.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sound/soc/intel/atom/sst/sst_acpi.c b/sound/soc/intel/atom/sst/sst_acpi.c
index 0e928d5..aec7408 100644
--- a/sound/soc/intel/atom/sst/sst_acpi.c
+++ b/sound/soc/intel/atom/sst/sst_acpi.c
@@ -236,6 +236,9 @@ static int sst_platform_get_resources(struct intel_sst_drv *ctx)
/* Find the IRQ */
ctx->irq_num = platform_get_irq(pdev,
ctx->pdata->res_info->acpi_ipc_irq_index);
+ if (ctx->irq_num <= 0)
+ return ctx->irq_num < 0 ? ctx->irq_num : -EIO;
+
return 0;
}
--
2.7.4
next prev parent reply other threads:[~2017-11-29 16:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 16:17 [PATCH 1/5 v5] ASoC: ep93xx-ac97: Fix platform_get_irq's error checking Arvind Yadav
2017-11-29 16:17 ` [PATCH 2/5 v5] ASoC: mt8173: " Arvind Yadav
2017-12-01 13:44 ` Applied "ASoC: mt8173: Fix platform_get_irq's error checking" to the asoc tree Mark Brown
2017-11-29 16:17 ` [PATCH 3/5 v5] ASoC: nuc900: Fix platform_get_irq's error checking Arvind Yadav
2017-12-01 13:44 ` Applied "ASoC: nuc900: Fix platform_get_irq's error checking" to the asoc tree Mark Brown
2017-11-29 16:17 ` Arvind Yadav [this message]
2017-12-01 13:44 ` Applied "ASoC: intel: sst: Handle return value of platform_get_irq" " Mark Brown
2017-11-29 16:17 ` [PATCH 5/5 v4] ASoC: intel: mfld: Handle return value of platform_get_irq Arvind Yadav
2017-12-01 13:43 ` Applied "ASoC: intel: mfld: Handle return value of platform_get_irq" to the asoc tree Mark Brown
2017-12-01 13:44 ` Applied "ASoC: ep93xx-ac97: Fix platform_get_irq's error checking" " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=deb09b18d95f81661dbb8136fec947a548af6a77.1511970158.git.arvind.yadav.cs@gmail.com \
--to=arvind.yadav.cs@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).