From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B1FFC433EF for ; Mon, 8 Nov 2021 14:20:54 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 919E9610E9 for ; Mon, 8 Nov 2021 14:20:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 919E9610E9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 808D715F9; Mon, 8 Nov 2021 15:20:00 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 808D715F9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1636381250; bh=2X7qXXJAQsiSxHZw59Sz9pcznrU78FCrb2euAT5bwZM=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=YKh+60AoLCHPsOMlCC7/poFUQFsL6SBP1D24hdTSN00icFUfpgPT/nOGUmVF0avLl xM5IM/zT/ZNWDFgX+XbrqCH21WAdeZKvTmaAMG4yPXhVH3lsqIKmi4ms4qpyqGbeic lzPt9EJ7aPgyo6LA4LJ7NQT9J5+ie1oO9qjN1SGM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 0A9F0F80107; Mon, 8 Nov 2021 15:20:00 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id BED46F8049E; Mon, 8 Nov 2021 15:19:58 +0100 (CET) Received: from m43-7.mailgun.net (m43-7.mailgun.net [69.72.43.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 8E5D4F80107 for ; Mon, 8 Nov 2021 15:19:50 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 8E5D4F80107 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="ICWsFe+X" DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1636381192; h=Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=MIB3Ty33QcWWd7DLZ2TPpTX1aewEAu4EvL5id/wfi4w=; b=ICWsFe+XI3UOkd8PpKr0wpPi7OCcbmyp7hlNqaeZDg85XQy4Pgbc268zEQPYVZ6iSXymLaUH Mz5bVzOzJjPERyWbCgxoWMJPLNWYu0SoW5yxuMtyfLHmryy+5gGw1PJw8+uujlWV+rTqdsit KvFjHf+lOToyacpwFeb/PZAs9hU= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI4ZmE2ZSIsICJhbHNhLWRldmVsQGFsc2EtcHJvamVjdC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-east-1.postgun.com with SMTP id 618932021b50ee50150da242 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 08 Nov 2021 14:19:46 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 76E30C4360D; Mon, 8 Nov 2021 14:19:45 +0000 (UTC) Received: from [10.242.143.72] (unknown [202.46.23.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: srivasam) by smtp.codeaurora.org (Postfix) with ESMTPSA id 0A603C4338F; Mon, 8 Nov 2021 14:19:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 0A603C4338F Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org Subject: Re: [PATCH v4 1/2] ASoC: google: dt-bindings: Add sc7280-herobrine machine bindings To: Rob Herring References: <1635519876-7112-1-git-send-email-srivasam@codeaurora.org> <1635519876-7112-2-git-send-email-srivasam@codeaurora.org> <0cf52203-249a-2f6c-6106-888631ac85fa@codeaurora.org> From: Srinivasa Rao Mandadapu Organization: Qualcomm India Private Limited. Message-ID: Date: Mon, 8 Nov 2021 19:49:37 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: devicetree@vger.kernel.org, Linux-ALSA , Banajit Goswami , linux-arm-msm , Mark Brown , Takashi Iwai , Liam Girdwood , Bjorn Andersson , "Gross, Andy" , Rohit kumar , Stephen Boyd , judyhsiao@chromium.org, Patrick Lai , "linux-kernel@vger.kernel.org" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 11/8/2021 7:30 PM, Rob Herring wrote: Thanks for Your inputs Rob!!! > On Mon, Nov 8, 2021 at 1:35 AM Srinivasa Rao Mandadapu > wrote: >> >> On 11/6/2021 7:00 AM, Rob Herring wrote: >> Thanks for Your time Rob!!! >>> On Tue, Nov 2, 2021 at 5:57 AM Srinivasa Rao Mandadapu >>> wrote: >>>> On 10/30/2021 12:37 AM, Stephen Boyd wrote: >>>> Thanks for Your time Stephen!!! >>>>> Quoting Srinivasa Rao Mandadapu (2021-10-29 08:04:35) >>>>>> diff --git a/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml b/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml >>>>>> new file mode 100644 >>>>>> index 0000000..3a781c8 >>>>>> --- /dev/null >>>>>> +++ b/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml >>>>>> @@ -0,0 +1,170 @@ >>>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>>>> +%YAML 1.2 >>>>>> +--- >>>>>> +$id: http://devicetree.org/schemas/sound/google,sc7280-herobrine.yaml# >>>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>>>> + >>>>>> +title: Google SC7280-Herobrine ASoC sound card driver >>>>>> + >>>>>> +maintainers: >>>>>> + - Srinivasa Rao Mandadapu >>>>>> + - Judy Hsiao >>>>>> + >>>>>> +description: >>>>>> + This binding describes the SC7280 sound card which uses LPASS for audio. >>>>>> + >>>>>> +properties: >>>>>> + compatible: >>>>>> + enum: >>>>>> + - google,sc7280-herobrine >>>>>> + >>>>>> + audio-routing: >>>>>> + $ref: /schemas/types.yaml#/definitions/non-unique-string-array >>>>>> + description: >>>>>> + A list of the connections between audio components. Each entry is a >>>>>> + pair of strings, the first being the connection's sink, the second >>>>>> + being the connection's source. >>>>>> + >>>>>> + model: >>>>>> + $ref: /schemas/types.yaml#/definitions/string >>>>>> + description: User specified audio sound card name >>>>>> + >>>>>> + "#address-cells": >>>>>> + const: 1 >>>>>> + >>>>>> + "#size-cells": >>>>>> + const: 0 >>>>>> + >>>>>> +patternProperties: >>>>>> + "^dai-link@[0-9a-f]$": >>>>>> + description: >>>>>> + Each subnode represents a dai link. Subnodes of each dai links would be >>>>>> + cpu/codec dais. >>>>>> + >>>>>> + type: object >>>>>> + >>>>>> + properties: >>>>>> + link-name: >>>>>> + description: Indicates dai-link name and PCM stream name. >>>>>> + $ref: /schemas/types.yaml#/definitions/string >>>>>> + maxItems: 1 >>>>>> + >>>>>> + reg: >>>>>> + maxItems: 1 >>>>>> + description: dai link address. >>>>>> + >>>>>> + cpu: >>>>>> + description: Holds subnode which indicates cpu dai. >>>>>> + type: object >>>>>> + properties: >>>>>> + sound-dai: true >>>>> Is sound-dai required? And additionalProperties is false? I think we >>>>> need that yet again. >>>> Okay. Will mark additionalPropertiesas true. >>> 'additiionalProperties: true' is almost never right. It's generally >>> only correct for schemas that are incomplete collections of >>> properties. >>> >>> Rob >> As per Stephen Suggestion. thought it's a solution. >> >> The sound-dai required here, and same is fallowed in SC7180 machine >> driver bindings. >> >> Could You please suggest better approach on this? > Exactly what Stephen said, add: > > required: > - sound-dai > > additionalProperties: false Okay. Then changes looks like below snippet. Please correct me If I am wrong.  ------  ------       codec:         description: Holds subnode which indicates codec dai.         type: object         properties:           sound-dai: true     required:       - link-name       - cpu       - codec       - reg *- sound-dai*     additionalProperties: false required:   - compatible   - model   - "#address-cells"   - "#size-cells" additionalProperties: false ------- ------- -- Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.