From: Jaroslav Kysela <perex@perex.cz>
To: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>,
alsa-devel@alsa-project.org
Cc: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH 1/2] pcm: hw: reinterpret the drain_silence setting
Date: Mon, 15 May 2023 11:06:54 +0200 [thread overview]
Message-ID: <dfe607f4-2cee-be2d-561f-1674e156edc0@perex.cz> (raw)
In-Reply-To: <20230515084106.3447657-1-oswald.buddenhagen@gmx.de>
On 15. 05. 23 10:41, Oswald Buddenhagen wrote:
> It makes no sense to have a config option which determines the entire
> silencing time, because useful values strongly depend on the period size
> runtime setting.
I would prefer a drain silence mode configuration field for this, if the
interpretation of the positive value is different. The current value is easy
to understand and it's really a corner case to not use the default (auto)
code. Even the period time may be forced in the configuration, so users can
compute the right value themselves.
Jaroslav
--
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
next prev parent reply other threads:[~2023-05-15 9:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 8:41 [PATCH 1/2] pcm: hw: reinterpret the drain_silence setting Oswald Buddenhagen
2023-05-15 8:41 ` [PATCH 2/2] pcm: hw: fix excessive silence fill on drain Oswald Buddenhagen
2023-05-15 9:06 ` Jaroslav Kysela [this message]
2023-05-15 9:55 ` [PATCH 1/2] pcm: hw: reinterpret the drain_silence setting Oswald Buddenhagen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfe607f4-2cee-be2d-561f-1674e156edc0@perex.cz \
--to=perex@perex.cz \
--cc=alsa-devel@alsa-project.org \
--cc=oswald.buddenhagen@gmx.de \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox