From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pierre-Louis Bossart Subject: Re: [RFC PATCH 26/40] soundwire: cadence_master: fix divider setting in clock register Date: Fri, 2 Aug 2019 12:30:42 -0500 Message-ID: References: <20190725234032.21152-1-pierre-louis.bossart@linux.intel.com> <20190725234032.21152-27-pierre-louis.bossart@linux.intel.com> <20190802171906.GB12733@vkoul-mobl.Dlink> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190802171906.GB12733@vkoul-mobl.Dlink> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Vinod Koul Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, tiwai@suse.de, broonie@kernel.org, gregkh@linuxfoundation.org, jank@cadence.com, srinivas.kandagatla@linaro.org, slawomir.blauciak@intel.com, Rander Wang , Sanyog Kale List-Id: alsa-devel@alsa-project.org On 8/2/19 12:19 PM, Vinod Koul wrote: > On 25-07-19, 18:40, Pierre-Louis Bossart wrote: >> From: Rander Wang >> >> The existing code uses an OR operation which would mix the original >> divider setting with the new one, resulting in an invalid >> configuration that can make codecs hang. > > This looked fine but fails to apply, feel free to send as a fix likely because it's on top of patch 25