From mboxrd@z Thu Jan  1 00:00:00 1970
From: Arvind Yadav <arvind.yadav.cs@gmail.com>
Subject: Re: [PATCH] ASoC: codecs: msm8916-wcd-analog: always
	true condition
Date: Thu, 24 Aug 2017 16:11:20 +0530
Message-ID: <e291ebaf-8b83-5fcf-0f64-d510b1f6bfc2@gmail.com>
References: <20170824100741.s4v24owbvocshr5n@mwanda>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mail-io0-f195.google.com (mail-io0-f195.google.com
 [209.85.223.195])
 by alsa0.perex.cz (Postfix) with ESMTP id 34E2A2675AC
 for <alsa-devel@alsa-project.org>; Thu, 24 Aug 2017 12:41:37 +0200 (CEST)
Received: by mail-io0-f195.google.com with SMTP id c8so1315132ioj.3
 for <alsa-devel@alsa-project.org>; Thu, 24 Aug 2017 03:41:37 -0700 (PDT)
In-Reply-To: <20170824100741.s4v24owbvocshr5n@mwanda>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Dan Carpenter <dan.carpenter@oracle.com>, Liam Girdwood <lgirdwood@gmail.com>, Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: alsa-devel@alsa-project.org, Axel Lin <axel.lin@ingics.com>, Damien Riegel <damien.riegel@savoirfairelinux.com>, kernel-janitors@vger.kernel.org, Takashi Iwai <tiwai@suse.com>, Mark Brown <broonie@kernel.org>, Takashi Sakamoto <o-takashi@sakamocchi.jp>, Bhumika Goyal <bhumirks@gmail.com>
List-Id: alsa-devel@alsa-project.org



On Thursday 24 August 2017 03:37 PM, Dan Carpenter wrote:
> Static checkers complain that unsigned int val is always >= 0.  The
> context is that snd_soc_read() returns -1U on error.  This is harmless
> because we're checking that CDC_A_MBHC_RESULT_1_BTN_RESULT_MASK is not
> set, and it will always be set for -1U.  I could have just removed the
> check against -1 but I preserved it because I thought it helped with
> readability.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Arvind Yadav<arvind.yadav.cs@gmail.com 
<mailto:arvind.yadav.cs@gmail.com>>
>
> diff --git a/sound/soc/codecs/msm8916-wcd-analog.c b/sound/soc/codecs/msm8916-wcd-analog.c
> index 4aa878d29098..549c269acc7d 100644
> --- a/sound/soc/codecs/msm8916-wcd-analog.c
> +++ b/sound/soc/codecs/msm8916-wcd-analog.c
> @@ -949,7 +949,7 @@ static irqreturn_t mbhc_btn_release_irq_handler(int irq, void *arg)
>   		u32 val = snd_soc_read(codec, CDC_A_MBHC_RESULT_1);
>   
>   		/* check if its BTN0 thats released */
> -		if ((val >= 0) && !(val & CDC_A_MBHC_RESULT_1_BTN_RESULT_MASK))
> +		if ((val != -1) && !(val & CDC_A_MBHC_RESULT_1_BTN_RESULT_MASK))
>   			priv->mbhc_btn0_pressed = false;
>   
>   	} else {