From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1546FC61DA4 for ; Tue, 14 Feb 2023 19:25:18 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 06687E7C; Tue, 14 Feb 2023 20:24:26 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 06687E7C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1676402716; bh=YaJ0/vzyPE93lfO9brhHqKXTla+RNyrMuB6BfPzFkHk=; h=Date:Subject:To:References:From:In-Reply-To:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=Nczvu9B8UWxWV+VGEy2HLZC/Wn5m8GLaCtXWVyJnB4jy5PtQMikigQLU1bv91Okmg 2YbuDZ2q62WAuYf2RT9Ufblctj8u3p/WOUy67L+9jL31ANrPYuKtrxwJzkq3n5tM2d 2gd8nHrq0E0A34S/WSlCZPAcA0fbaQ+3JKiCDbEY= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id AE42EF8053D; Tue, 14 Feb 2023 20:23:12 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1D701F804B2; Tue, 14 Feb 2023 20:23:06 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 09F13F8047C for ; Tue, 14 Feb 2023 20:22:59 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 09F13F8047C Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=jaaxU4I0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676402581; x=1707938581; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=YaJ0/vzyPE93lfO9brhHqKXTla+RNyrMuB6BfPzFkHk=; b=jaaxU4I0a/i2JNIUumh+fC+tx8UkIHRPcE89Z5fdWIhg969tMIVeZvfj ouu5hMjvgVcEbKR133M1HWNKBvpfoNdDQOg5Qw+OXUJi+aP3eN2NQm03l bwS1++WBUM3mOobjHkbq8JEFtV0x59tt4bxi6+EoEZD1DNxFy9h47HjZA gJR2nZq3H1ZbOGCPgyqk7I1QCuXArQKbB3jhALIM1S+nUBz7nXEKJyLTi MMsmFGQC4hz7wzlIjV6pTZ96oPTMXWJfKj231RIcuNUT8/t38NkHNHWFE p7qj53fOMBcNmLamFWhJJlwBK8YgrMiY8yjLb8xwOATw0UOsbOX9n0eDl g==; X-IronPort-AV: E=McAfee;i="6500,9779,10621"; a="314893726" X-IronPort-AV: E=Sophos;i="5.97,297,1669104000"; d="scan'208";a="314893726" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2023 11:22:54 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10621"; a="778485245" X-IronPort-AV: E=Sophos;i="5.97,297,1669104000"; d="scan'208";a="778485245" Received: from parthgup-mobl2.amr.corp.intel.com (HELO [10.209.175.23]) ([10.209.175.23]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2023 11:22:53 -0800 Message-ID: Date: Tue, 14 Feb 2023 07:35:32 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.7.1 Subject: Re: [PATCH V2 7/8] soundwire: amd: handle soundwire wake enable interrupt Content-Language: en-US To: "Mukunda,Vijendar" , vkoul@kernel.org References: <20230213094031.2231058-1-Vijendar.Mukunda@amd.com> <20230213094031.2231058-8-Vijendar.Mukunda@amd.com> <586a9f58-f660-1ac0-0506-91362b25f75d@amd.com> From: Pierre-Louis Bossart In-Reply-To: <586a9f58-f660-1ac0-0506-91362b25f75d@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Message-ID-Hash: BZ7MOVEPVZ445NAEFWPVGAJCJKPBD6VZ X-Message-ID-Hash: BZ7MOVEPVZ445NAEFWPVGAJCJKPBD6VZ X-MailFrom: pierre-louis.bossart@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: amadeuszx.slawinski@linux.intel.com, Mario.Limonciello@amd.com, Sunil-kumar.Dommati@amd.com, Basavaraj.Hiregoudar@amd.com, Mastan.Katragadda@amd.com, Arungopal.kondaveeti@amd.com, Bard Liao , Sanyog Kale , "moderated list:SOUNDWIRE SUBSYSTEM" , open list X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: >>> static void amd_sdw_irq_thread(struct work_struct *work) >>> { >>> struct amd_sdw_manager *amd_manager = >>> @@ -945,6 +952,9 @@ static void amd_sdw_irq_thread(struct work_struct *work) >>> status_change_0to7 = acp_reg_readl(amd_manager->mmio + ACP_SW_STATE_CHANGE_STATUS_0TO7); >>> dev_dbg(amd_manager->dev, "%s [SDW%d] SDW INT: 0to7=0x%x, 8to11=0x%x\n", >>> __func__, amd_manager->instance, status_change_0to7, status_change_8to11); >>> + if (status_change_8to11 & AMD_SDW_WAKE_STAT_MASK) >>> + return amd_sdw_process_wake_event(amd_manager); >>> + >> it's not clear what 8to11 might have to do with the wake enable? >> >> Can't you have a wake for devices 1..7? > It can wake any device from 1..11 . > SoundWire Wake interrupt status bit is part of 8to11 register. You probably want to explain what status_change_0to7 and status_change_8to11 actually control, it's not very intuitive for me to see device 1 interrupt being handled in status_change_8to11?