From: "Piotr Zaryk" <pzaryk@gmail.com>
To: Alsa-devel@alsa-project.org
Subject: Re: Patch - ESI Maya44 driver
Date: Sat, 5 Apr 2008 10:07:51 +0200 [thread overview]
Message-ID: <e5888dbe0804050107o54ca8e8dne8d6fdd766d9d843@mail.gmail.com> (raw)
In-Reply-To: <47ED5E29.4040400@lightshed.de>
Will be the patch finally included to alsa?
2008/3/28, Rainer Zimmermann <mail@lightshed.de>:
>
>
> Hi Takashi,
>
> sorry about this. here's the fixed patch, identical to the last except for
> the coding style fixes.
>
> -Rainer
>
>
> Takashi Iwai wrote:
>
> > At Fri, 21 Mar 2008 12:27:49 +0100,
> > Rainer Zimmermann wrote:
> >
> > > Hi Takashi,
> > >
> > > here's the maya44 patch.
> > >
> > > This is a patch against the current alsa-kernel tree.
> > >
> >
> > Thanks. This looks better than the previous version.
> >
> > I did add 2 definitions to ice1712.h (snd_ice1724_get_route_val and
> > > snd_ice1724_put_route_val), which allowed me to move some of the maya44
> > > specific code to maya44.c .
> > >
> >
> > We could do it in a bit cleaer way, but I think it's OK as is.
> >
> > There are still a few maya44 special cases in ice1724.c, because maya44
> > > uses the "con" channel and routing switches differently. This is not really
> > > clean style I think, but I would suggest sorting this out later, as it would
> > > again require larger changes to ice1724.c and testing with other hardware.
> > >
> >
> > Agreed. This kind of clean up can be done later.
> >
> > Hope everything is ok with you, for now.
> > >
> > > This patch does *not* limit the sampling rate to 96kHz for capture, as
> > > discussed before.
> > >
> >
> > The patch looks apparently not compliant to the kernel coding style.
> > Could you fix at least the issues reported by checkpatch.pl (the
> > latest one)?
> >
> >
> > thanks,
> >
> > Takashi
> > _______________________________________________
> > Alsa-devel mailing list
> > Alsa-devel@alsa-project.org
> > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> >
> >
>
> --
> Lightshed IT Services
> Löfflerstr. 27, 22765 Hamburg, Germany * mail@lightshed.de *
> www.lightshed.de
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
>
>
--
Regards,
Piotr Zaryk
next prev parent reply other threads:[~2008-04-05 8:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-21 11:27 Patch - ESI Maya44 driver Rainer Zimmermann
2008-03-22 9:24 ` Takashi Iwai
2008-03-28 21:07 ` Rainer Zimmermann
2008-04-05 8:07 ` Piotr Zaryk [this message]
2008-04-14 10:43 ` Takashi Iwai
2008-05-09 7:22 ` Piotr Zaryk
2008-05-09 10:51 ` Takashi Iwai
-- strict thread matches above, loose matches on Subject: below --
2008-07-19 17:02 midragius
2008-07-21 9:27 ` midragius
2008-07-27 8:01 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5888dbe0804050107o54ca8e8dne8d6fdd766d9d843@mail.gmail.com \
--to=pzaryk@gmail.com \
--cc=Alsa-devel@alsa-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox