From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4136EEB64DD for ; Fri, 30 Jun 2023 08:35:26 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3C740846; Fri, 30 Jun 2023 10:34:34 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3C740846 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1688114124; bh=XGNfAYSZOCtahPicxoKEB+uWG71sQCJtqIk+i/6n7fA=; h=Date:Subject:To:CC:References:From:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=X40emzcMWYZNf4NrlZumw8iaIafzENTDgOqltL8t61mhPS8VTXStrQ4U6oUenDT7A wGsJ+Fb/OUCB9Z1GfVx8PtslL+CcJh6QgyIXN29phTnhLHnhTpNO+Dqpi1cRP9mOVo /ql2XejPcGh+TawHLo/+HMy9UAGpXEr3MS9oQJlY= Received: by alsa1.perex.cz (Postfix, from userid 50401) id AC9B4F80570; Fri, 30 Jun 2023 10:33:41 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 3FCB2F80563; Fri, 30 Jun 2023 10:33:41 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0C337F80246; Fri, 30 Jun 2023 03:42:57 +0200 (CEST) Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A3444F80169 for ; Fri, 30 Jun 2023 03:42:43 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A3444F80169 Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 419057FD3; Fri, 30 Jun 2023 09:42:32 +0800 (CST) Received: from EXMBX172.cuchost.com (172.16.6.92) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 30 Jun 2023 09:42:32 +0800 Received: from [192.168.125.93] (183.27.97.206) by EXMBX172.cuchost.com (172.16.6.92) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 30 Jun 2023 09:42:31 +0800 Message-ID: Date: Fri, 30 Jun 2023 09:42:30 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v1 1/5] ASoC: dt-bindings: Add StarFive JH7110 dummy PWM-DAC transmitter To: Krzysztof Kozlowski , Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Walker Chen" , Xingyu Wu , Emil Renner Berthing CC: , , , References: <20230626110909.38718-1-hal.feng@starfivetech.com> <20230626110909.38718-2-hal.feng@starfivetech.com> <92171465-d2ba-c3ba-aa55-0f705e924a0f@linaro.org> Content-Language: en-US From: Hal Feng In-Reply-To: <92171465-d2ba-c3ba-aa55-0f705e924a0f@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [183.27.97.206] X-ClientProxiedBy: EXCAS064.cuchost.com (172.16.6.24) To EXMBX172.cuchost.com (172.16.6.92) X-YovoleRuleAgent: yovoleflag X-MailFrom: hal.feng@starfivetech.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1 Message-ID-Hash: FJQGYJLIFV3ANSTT4PCDXDA2WR2VTNDE X-Message-ID-Hash: FJQGYJLIFV3ANSTT4PCDXDA2WR2VTNDE X-Mailman-Approved-At: Fri, 30 Jun 2023 08:33:34 +0000 X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: <> List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 26 Jun 2023 17:32:04 +0200, Krzysztof Kozlowski wrote: > On 26/06/2023 13:09, Hal Feng wrote: >> Add bindings for StarFive JH7110 dummy PWM-DAC transmitter. >> >> Signed-off-by: Hal Feng >> --- >> .../sound/starfive,jh7110-pwmdac-dit.yaml | 38 +++++++++++++++++++ >> 1 file changed, 38 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/sound/starfive,jh7110-pwmdac-dit.yaml >> >> diff --git a/Documentation/devicetree/bindings/sound/starfive,jh7110-pwmdac-dit.yaml b/Documentation/devicetree/bindings/sound/starfive,jh7110-pwmdac-dit.yaml >> new file mode 100644 >> index 000000000000..bc43e3b1e9d2 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/sound/starfive,jh7110-pwmdac-dit.yaml >> @@ -0,0 +1,38 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/sound/starfive,jh7110-pwmdac-dit.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: StarFive JH7110 Dummy PWM-DAC Transmitter >> + >> +maintainers: >> + - Hal Feng >> + >> +allOf: >> + - $ref: dai-common.yaml# >> + >> +properties: >> + compatible: >> + const: starfive,jh7110-pwmdac-dit >> + >> + "#sound-dai-cells": >> + const: 0 >> + >> + sound-name-prefix: true > > Drop Will fix it. > >> + >> +required: >> + - compatible >> + - "#sound-dai-cells" >> + >> +additionalProperties: false > > Instead: unevaluatedProperties: false Will fix. Thanks. >> + >> +examples: >> + - | >> + pwmdac-dit { > > pwmdac? No. For a similar implementation, you can refer to "spdif-dit" in arch/arm64/boot/dts/rockchip/rk3328-rock64.dts Best regards, Hal