From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF739C7619A for ; Wed, 5 Apr 2023 15:04:05 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B990E1FE; Wed, 5 Apr 2023 17:03:12 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B990E1FE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1680707042; bh=dFlO+IoyPt/cvrM8e5U9Z6n3Lak/MZq3BRfErTyVWhM=; h=Date:Subject:To:References:From:In-Reply-To:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=UrU+cS97cBo0a2175gXrLwzXu3dpQ0yhbq4KmNpgV0rpz4GwnYAvmbZllXMHfxt8x zMYfmDSvJAZoZ7mX3X9RoOZv3wlUX6y6hiSVSKA+kRx7ONBmf/n8l1NrqHgUF537yu VYTN6fBEKicIYfN36XWLXZNoTe/GY4weaUPdD/Es= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 1B54FF8024C; Wed, 5 Apr 2023 17:02:50 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id BC5ABF8024C; Wed, 5 Apr 2023 17:02:44 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 8F83EF8015B for ; Wed, 5 Apr 2023 17:02:34 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 8F83EF8015B Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=KZCcmhIP DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680706956; x=1712242956; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=dFlO+IoyPt/cvrM8e5U9Z6n3Lak/MZq3BRfErTyVWhM=; b=KZCcmhIPBQuATTdMgkcTwvxe/hDkC+hO3Ehbi85z0BcTKYOyzMUkfV4c yz03bQmIlm86AfMo7+RxGDxznukt0Es7HsujOf9osiYMMevtkPvY1KW96 ZwebQhYVKSYl/xDGayTVyDQ2y5Xw4oDKuj9CMfqbHpqld0RpcoqOohyGS hIIjkqb29jYsxsn1h6RtVkNJakFFo+/gpjClk9E6UCvnvOc2dCfyAPvMg M/dmn1n66KZVJHG+H2pwTaYQOUxp1V1456aOlihF2d3DZDQsCddpTJXor 8KVqwW90r9tW6wLpMptfKEJBQoM58afvs6AyQm5pJKpQL+j6m8VJCZo9A g==; X-IronPort-AV: E=McAfee;i="6600,9927,10671"; a="407559720" X-IronPort-AV: E=Sophos;i="5.98,321,1673942400"; d="scan'208";a="407559720" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Apr 2023 08:01:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10671"; a="686779878" X-IronPort-AV: E=Sophos;i="5.98,321,1673942400"; d="scan'208";a="686779878" Received: from mlokuyad-mobl.amr.corp.intel.com (HELO [10.212.149.36]) ([10.212.149.36]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Apr 2023 08:01:56 -0700 Message-ID: Date: Wed, 5 Apr 2023 10:01:56 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.9.0 Subject: Re: [PATCH] soundwire: qcom: Fix enumeration of second device on the bus Content-Language: en-US To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Vinod Koul , Bard Liao , Sanyog Kale , Srinivas Kandagatla , linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org References: <20230405142926.842173-1-krzysztof.kozlowski@linaro.org> From: Pierre-Louis Bossart In-Reply-To: <20230405142926.842173-1-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Message-ID-Hash: DQBQMQVEOMQ3LIAALSB2TIYLSKOGIBL7 X-Message-ID-Hash: DQBQMQVEOMQ3LIAALSB2TIYLSKOGIBL7 X-MailFrom: pierre-louis.bossart@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: stable@vger.kernel.org, Patrick Lai X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 4/5/23 09:29, Krzysztof Kozlowski wrote: > Some Soundwire buses (like &swr0 on Qualcomm HDK8450) have two devices, > which can be brought from powerdown state one after another. We need to > keep enumerating them on each slave attached interrupt, otherwise only > first will appear. > > Cc: > Fixes: a6e6581942ca ("soundwire: qcom: add auto enumeration support") > Signed-off-by: Krzysztof Kozlowski > > --- > > Cc: Patrick Lai > --- > drivers/soundwire/qcom.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c > index c296e0bf897b..1e5077d91f59 100644 > --- a/drivers/soundwire/qcom.c > +++ b/drivers/soundwire/qcom.c > @@ -587,14 +587,9 @@ static irqreturn_t qcom_swrm_irq_handler(int irq, void *dev_id) > case SWRM_INTERRUPT_STATUS_CHANGE_ENUM_SLAVE_STATUS: > dev_dbg_ratelimited(swrm->dev, "SWR new slave attached\n"); > swrm->reg_read(swrm, SWRM_MCP_SLV_STATUS, &slave_status); > - if (swrm->slave_status == slave_status) { > - dev_dbg(swrm->dev, "Slave status not changed %x\n", > - slave_status); it's not clear to me how removing this test helps with the two-device configuration? Or is this a case where the status for both devices changes at the same time but the interrupt status remains set, so the next iteration of the loop is ignored? > - } else { > - qcom_swrm_get_device_status(swrm); > - qcom_swrm_enumerate(&swrm->bus); > - sdw_handle_slave_status(&swrm->bus, swrm->status); > - } > + qcom_swrm_get_device_status(swrm); > + qcom_swrm_enumerate(&swrm->bus); > + sdw_handle_slave_status(&swrm->bus, swrm->status); > break; > case SWRM_INTERRUPT_STATUS_MASTER_CLASH_DET: > dev_err_ratelimited(swrm->dev,