From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2F13C77B7A for ; Thu, 1 Jun 2023 16:08:16 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A51FD826; Thu, 1 Jun 2023 18:07:24 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A51FD826 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1685635694; bh=2Mn6x5IdzOh+PTJA922z5mAJ2hM16u2Tinm4zVtt0OA=; h=Date:Subject:To:CC:References:From:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=qad8H5MaUz3rluk6Otnl13eWWzap3/17CTGKxNWqefx/ZRGejVAY20rkry5IA9+v4 8j2XfKRGQLIrD6ouh4erF0nKUfqRqdoxZp+BjDti2k//O3OejfH1HVj9w8AegbzaUv L3nzpANTr0BYGCVHmEJsqYZaX+/kGhr8KixT/rAo= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 12362F8063D; Thu, 1 Jun 2023 18:03:18 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 2CED1F8063C; Thu, 1 Jun 2023 18:03:18 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8E1D7F8042F; Wed, 31 May 2023 08:30:33 +0200 (CEST) Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 52366F800DF for ; Wed, 31 May 2023 08:30:25 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 52366F800DF Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 8674F24E1FC; Wed, 31 May 2023 14:30:21 +0800 (CST) Received: from EXMBX168.cuchost.com (172.16.6.78) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Wed, 31 May 2023 14:30:21 +0800 Received: from [192.168.125.124] (113.72.147.198) by EXMBX168.cuchost.com (172.16.6.78) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Wed, 31 May 2023 14:30:20 +0800 Message-ID: Date: Wed, 31 May 2023 14:30:19 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v5 3/3] riscv: dts: starfive: add the node and pins configuration for tdm To: Hal Feng , Mark Brown , Liam Girdwood , Claudiu Beznea , Jaroslav Kysela , "Takashi Iwai" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Emil Renner Berthing" CC: , , , References: <20230526145402.450-1-walker.chen@starfivetech.com> <20230526145402.450-4-walker.chen@starfivetech.com> Content-Language: en-US From: Walker Chen In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [113.72.147.198] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX168.cuchost.com (172.16.6.78) X-YovoleRuleAgent: yovoleflag X-MailFrom: walker.chen@starfivetech.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1 Message-ID-Hash: IFAKEKBT2VZ6W5OZ3CVFQ6QDFALW4KGN X-Message-ID-Hash: IFAKEKBT2VZ6W5OZ3CVFQ6QDFALW4KGN X-Mailman-Approved-At: Thu, 01 Jun 2023 16:02:28 +0000 X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2023/5/31 14:23, Hal Feng wrote: > On Fri, 26 May 2023 22:54:02 +0800, Walker Chen wrote: >> Add the tdm controller node and pins configuration of tdm for the >> StarFive JH7110 SoC. >> >> Signed-off-by: Walker Chen >> --- >> .../jh7110-starfive-visionfive-2.dtsi | 40 +++++++++++++++++++ >> arch/riscv/boot/dts/starfive/jh7110.dtsi | 21 ++++++++++ >> 2 files changed, 61 insertions(+) >> >> diff --git a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi >> index 1155b97b593d..19b5954ee72d 100644 >> --- a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi >> +++ b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi >> @@ -214,6 +214,40 @@ >> slew-rate = <0>; >> }; >> }; >> + >> + tdm0_pins: tdm0-pins { >> + tdm0-pins-tx { > > Use consistent naming, so > > tdm_pins: tdm-0 { > tx-pins { > >> + pinmux = > + GPOEN_ENABLE, >> + GPI_NONE)>; >> + bias-pull-up; >> + drive-strength = <2>; >> + input-disable; >> + input-schmitt-disable; >> + slew-rate = <0>; >> + }; >> + >> + tdm0-pins-rx { > > rx-pins { > >> + pinmux = > + GPOEN_DISABLE, >> + GPI_SYS_TDM_RXD)>; >> + input-enable; >> + }; >> + >> + tdm0-pins-sync { > > sync-pins { > >> + pinmux = > + GPOEN_DISABLE, >> + GPI_SYS_TDM_SYNC)>; >> + input-enable; >> + }; >> + >> + tdm0-pins-pcmclk { > > pcmclk-pins { > >> + pinmux = > + GPOEN_DISABLE, >> + GPI_SYS_TDM_CLK)>; >> + input-enable; >> + }; >> + }; >> }; >> >> &uart0 { >> @@ -221,3 +255,9 @@ >> pinctrl-0 = <&uart0_pins>; >> status = "okay"; >> }; >> + >> +&tdm { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&tdm0_pins>; > > pinctrl-0 = <&tdm_pins>; > > Best regards, > Hal OK, I'll update these node's name in the next submit. Thanks. Best regards, Walker