From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 68ECBC46467 for ; Wed, 11 Jan 2023 01:21:20 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D292C30B3; Wed, 11 Jan 2023 02:20:27 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D292C30B3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1673400077; bh=akataVV8/0DapSMoYhbnfdEzhpmfzhdfJCigD6PWqj0=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=nF0xOizlJ0S4pNOSkhZ57hqdZ7OzBrGPFRHJw5pLZIRIMwjCfV3T0CRzsa3isB07Z jXe1pWAHU2ev87QOnrV0dcx70j6gtfSbgsEyvOjj2rt2ILTAZFf51u8QPS7UL9VNtK UHsJwgm/OvWH0/EHcR1pZ3/KaRgnQpeEb6XNvK7Y= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 88360F804BD; Wed, 11 Jan 2023 02:20:27 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 48F1CF804C1; Wed, 11 Jan 2023 02:20:26 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 36120F800C7 for ; Wed, 11 Jan 2023 02:20:23 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 36120F800C7 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=BUw9/qIv DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673400025; x=1704936025; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=akataVV8/0DapSMoYhbnfdEzhpmfzhdfJCigD6PWqj0=; b=BUw9/qIvpevPoPp6qfQg6FzQZSGFkAybvximgJUjWuh7xY5PdDNXmQf8 AkILzZd0zq/b2pJ9Hii3T51iiBXgDrXqVL1oTmZSj9esZMiEW3Ad3HA13 JB3X+IpU5ycOtIigemrTckX27Y88Wm4oC0OEaffGFV7zFTCQaL/Z92WVb jNFC4C3DuCZs3Z65+U43J0wlK7gDTwooPOkyxh/Lm9v0AnTvblAuQt2KE kkXVJmRQqIS8JAZ7PlU7ljRsv3WyuKSni/nIcRea3giUeuB02nrrePNId RnNTWJybXPB8Ac7JQuqMosWUa7IOEKi0gq/T+ItnqvIBX8kAnrzQ/4YRr w==; X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="409538750" X-IronPort-AV: E=Sophos;i="5.96,315,1665471600"; d="scan'208";a="409538750" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jan 2023 17:20:10 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="689612544" X-IronPort-AV: E=Sophos;i="5.96,315,1665471600"; d="scan'208";a="689612544" Received: from bphilli1-mobl1.amr.corp.intel.com (HELO [10.209.156.204]) ([10.209.156.204]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jan 2023 17:20:08 -0800 Message-ID: Date: Tue, 10 Jan 2023 19:20:08 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.4.2 Subject: Re: [PATCH v1 2/6] ASoC: Intel: bytcht_es8316: Drop reference count of ACPI device after use Content-Language: en-US To: Andy Shevchenko , Mark Brown , Vijendar Mukunda , Hans de Goede , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org References: <20230102203014.16041-1-andriy.shevchenko@linux.intel.com> <20230102203014.16041-2-andriy.shevchenko@linux.intel.com> From: Pierre-Louis Bossart In-Reply-To: <20230102203014.16041-2-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cezary Rojewski , Kai Vehmanen , Peter Ujfalusi , Takashi Iwai , Liam Girdwood , Ranjani Sridharan , Bard Liao Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 1/2/23 14:30, Andy Shevchenko wrote: > Theoretically the device might gone if its reference count drops to 0. > This might be the case when we try to find the first physical node of > the ACPI device. We need to keep reference to it until we get a result > of the above mentioned call. Refactor the code to drop the reference > count at the correct place. > > While at it, move to acpi_dev_put() as symmetrical call to the > acpi_dev_get_first_match_dev(). > > Fixes: 3c22a73fb873 ("ASoC: Intel: bytcht_es8316: fix HID handling") > Signed-off-by: Andy Shevchenko How do we proceed for this patchset? I am happy to ack a v2 if Andy splits the AMD and Intel patches w/ a cover letter, but this could also be added directly if there is no objection.