Re: [PATCH 12/19] ASoC: SOF: Intel: Set the default firmware library path for IPC4

[Cezary Rojewski <cezary.rojewski@intel.com>]

On 2022-10-19 1:16 PM, Péter Ujfalusi wrote:
> at the moment:
> # ls -al /lib/firmware/intel/ | wc -l
> 108
> 
> We might have 2 sets of binaries per platform, one using product key,
> other using community key.
> 
> If we dump everything in one directory (/lib/firmware/intel/), things
> will go out of hand pretty easily which can be somehow handled with
> complex file naming. This is only for the basefw, then we have the
> libraries (however they are sourced) with again two sets of keys, platforms.
> 
> Surely it can be done, but historically SOF prefers to use directories
> instead of pre/mid/post-fixing patterns of file names.

The concern is understandable. We haven't said that firmware files 
should be put directly under intel/ though.

> Also note that SOF is looking for a module UUID when trying to load a
> library we don't track arbitrary file names (see cover letter).

Neither 'dsp_fw_' nor 'dsp_lib_' prefix is arbitrary. A library may 
consist of more than one module, each with unique UUID. In general, 
'library' does not equal 'module'. Now, when speaking of modules, 
firmware-loading procedure that searches for file with certain UUID in 
its name is part of other drivers too and I haven't questioned that - 
it's perfectly fine and we're making use of the method ourselves.


Regards,
Czarek