From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pierre-Louis Bossart Subject: Re: [alsa-devel] [RFC PATCH 31/40] soundwire: intel: move shutdown() callback and don't export symbol Date: Fri, 26 Jul 2019 09:46:34 -0500 Message-ID: References: <20190725234032.21152-1-pierre-louis.bossart@linux.intel.com> <20190725234032.21152-32-pierre-louis.bossart@linux.intel.com> <39318aab-b1b4-2cce-c408-792a5cc343dd@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <39318aab-b1b4-2cce-c408-792a5cc343dd@intel.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Cezary Rojewski Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, tiwai@suse.de, broonie@kernel.org, vkoul@kernel.org, gregkh@linuxfoundation.org, jank@cadence.com, srinivas.kandagatla@linaro.org, slawomir.blauciak@intel.com, Sanyog Kale List-Id: alsa-devel@alsa-project.org On 7/26/19 5:38 AM, Cezary Rojewski wrote: > On 2019-07-26 01:40, Pierre-Louis Bossart wrote: >> +void intel_shutdown(struct snd_pcm_substream *substream, >> +            struct snd_soc_dai *dai) >> +{ >> +    struct sdw_cdns_dma_data *dma; >> + >> +    dma = snd_soc_dai_get_dma_data(dai, substream); >> +    if (!dma) >> +        return; >> + >> +    snd_soc_dai_set_dma_data(dai, substream, NULL); >> +    kfree(dma); >> +} > > Correct me if I'm wrong, but do we really need to _get_dma_ here? > _set_dma_ seems bulletproof, same for kfree. I must admit I have no idea why we have a reference to DMAs here, this looks like an abuse to store a dai-specific context, and the initial test looks like copy-paste to detect invalid configs, as done in other callbacks. Vinod and Sanyog might have more history than me here.