From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5A19C10F27 for ; Mon, 9 Mar 2020 17:44:25 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4003520866 for ; Mon, 9 Mar 2020 17:44:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="i16wZNTQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4003520866 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9C8691681; Mon, 9 Mar 2020 18:43:33 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9C8691681 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1583775863; bh=zKxoTtGOr5Qk8j4TDYusuoKQRRTuJr7yx29AyI8n2zo=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=i16wZNTQkZZasff3u1bfVv4Lsx2TmWrIcBLBJTBfj2dl28xQYol4yPV65gq1Koxa1 m2ilfAr2+tf9DWp00cVt+nKHAhJgl+yEDrogKDpKAg32C1y1ie6sYuS5YN6+bTEOps U5B+fjX4uupz2D7aGGOJFC1BAU3ocwUwN7Z0/cm4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 11529F800DA; Mon, 9 Mar 2020 18:43:33 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3B31AF801EB; Mon, 9 Mar 2020 18:43:31 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id EA972F80123 for ; Mon, 9 Mar 2020 18:43:26 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz EA972F80123 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Mar 2020 10:43:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,534,1574150400"; d="scan'208";a="231010250" Received: from crojewsk-mobl1.ger.corp.intel.com (HELO [10.252.15.110]) ([10.252.15.110]) by orsmga007.jf.intel.com with ESMTP; 09 Mar 2020 10:43:22 -0700 Subject: Re: [PATCH 1/7] ASoC: Intel: Skylake: Remove superfluous chip initialization To: Pierre-Louis Bossart , alsa-devel@alsa-project.org References: <20200305145314.32579-1-cezary.rojewski@intel.com> <20200305145314.32579-2-cezary.rojewski@intel.com> <8dc83af4-c4af-1bdd-5d59-f13598037f96@intel.com> From: Cezary Rojewski Message-ID: Date: Mon, 9 Mar 2020 18:43:21 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: vkoul@kernel.org, broonie@kernel.org, tiwai@suse.com, lgirdwood@gmail.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 2020-03-09 17:48, Pierre-Louis Bossart wrote: >> DRM is quite a tree, you got to be more specific. Tested with i915=m >> and DRM=m. I hope we mean the same thing when mentioning 'race'. There >> is an obvious initialization race between hda bus drv and i915 which >> requires one to follow a tight operation order in order to not lose >> i915 codec on hda link and thus be able to enumerate it properly. > > I meant CONFIG_DRM=m, yes, thanks for the clarification. > > With the DRM as module, it took more time to establish the > communication. That's probably changed if we do all the inits in a > workqueue now. > So, does the DRM=m & i915=m test satisfy you? >> >> On top of that, as you mentioned (by the link) this series addresses >> missing DMIC configuration in conjunction with HDA +/- iDisp AND >> shields against no-NHLT configuration. On Dell XPS 9350 lack on of >> NHLT was the biggest problem - that's why I'd like that issue not to >> be forgotten about. > > yes, but we don't want the driver to be auto-selected on SKL w/o DMICs, > since it'd break existing devices who don't have a topology file installed. My patch does not touch any of kconfig stuff. I'd prefer anything that goes into disable/enable kconfig bucket to be split into a separate patch. Don't believe SKL somehow gets automatically selected on these. On the machines I've tested fixes with, legacy HDaudio driver was the primary option/ drv.