Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jack Yu <jack.yu@realtek.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	"broonie@kernel.org" <broonie@kernel.org>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>
Cc: "Oder Chiou" <oder_chiou@realtek.com>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"lars@metafoo.de" <lars@metafoo.de>,
	"kent_chen@realtek.com [陳建宏]" <kent_chen@realtek.com>,
	陳昶志 <kenny_chen@realtek.com>,
	"Derek [方德義]" <derek.fang@realtek.com>,
	"Shuming [范書銘]" <shumingf@realtek.com>,
	"Flove(HsinFu)" <flove@realtek.com>
Subject: RE: [PATCH] ASoC: rt1015p: add acpi device id for rt1015p
Date: Wed, 10 Mar 2021 02:09:36 +0000	[thread overview]
Message-ID: <eeb69d18b3a5449a9a3497777afda052@realtek.com> (raw)
In-Reply-To: <f4327b67-7202-0a4c-69af-93a4a1982dfe@linux.intel.com>

> >>> +#ifdef CONFIG_ACPI
> >>> +static const struct acpi_device_id rt1015p_acpi_match[] = {
> >>> +	{ "ALCP1015", 0},
> >>
> >> This isn't much better, ALC is not a vendor ID as defined by
> >> https://uefi.org/PNP_ACPI_Registry
> >>
> >> I've ask for guidance from Intel ACPI folks on this, please stay tuned.
> >>
> >
> > Hi Pierre,
> >
> > Is there any update from Intel ACPI team regarding to this ID format issue?
> 
> Sorry about the delay.
> 
> It seems that the options are limited. The HID needs to be made of two parts,
> vendor ID and part ID.
> 
> For the vendor ID, you may use the PNP ID (RTL) or the PCI ID (10EC).
> 
> For the part ID, you are limited to 4 hex-digits. I didn't get any positive answers
> on how to support '1015P', the only solution seems to be to create a new part
> number, or detect at run-time which of the '1015' skews is actually used.
> 

Actually this driver is also used for rt1015 IC, the only difference is that rt1015.c is for i2c mode
and rt1015p is for non-i2c mode of rt1015 IC, so I think it's ok to use the same part ID (different vendor ID) for two drivers.
How do you think if we use "RTL1015" instead?


  reply	other threads:[~2021-03-10  2:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-26  2:05 [PATCH] ASoC: rt1015p: add acpi device id for rt1015p jack.yu
2021-02-26 21:48 ` Pierre-Louis Bossart
2021-03-08  6:10   ` Jack Yu
2021-03-09 20:26     ` Pierre-Louis Bossart
2021-03-10  2:09       ` Jack Yu [this message]
2021-03-10 15:39         ` Pierre-Louis Bossart
2021-03-12 20:23 ` Mark Brown
  -- strict thread matches above, loose matches on Subject: below --
2021-02-25  8:45 jack.yu
2021-02-25  9:40 ` Tzung-Bi Shih
2021-02-25 17:15 ` Pierre-Louis Bossart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eeb69d18b3a5449a9a3497777afda052@realtek.com \
    --to=jack.yu@realtek.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=derek.fang@realtek.com \
    --cc=flove@realtek.com \
    --cc=kenny_chen@realtek.com \
    --cc=kent_chen@realtek.com \
    --cc=lars@metafoo.de \
    --cc=lgirdwood@gmail.com \
    --cc=oder_chiou@realtek.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=shumingf@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox