From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pierre-Louis Bossart Subject: Re: [PATCH] ASoC: Intel: Boards: Add CNL RT274 I2S machine driver Date: Tue, 28 Nov 2017 10:44:50 -0600 Message-ID: References: <20171127124437.8441-1-guneshwor.o.singh@intel.com> <5bdd77e1-fb83-0626-c377-a457294ca38d@linux.intel.com> <20171128162415.GV3187@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by alsa0.perex.cz (Postfix) with ESMTP id F331D267845 for ; Tue, 28 Nov 2017 17:44:55 +0100 (CET) In-Reply-To: <20171128162415.GV3187@localhost> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Vinod Koul Cc: ALSA ML , Takashi Iwai , Guneshwor Singh , Liam Girdwood , Patches Audio , Mark Brown List-Id: alsa-devel@alsa-project.org On 11/28/2017 10:24 AM, Vinod Koul wrote: > On Mon, Nov 27, 2017 at 08:45:16AM -0600, Pierre-Louis Bossart wrote: >> On 11/27/17 6:44 AM, Guneshwor Singh wrote: >>> Add CNL I2S machine driver using Realtek RT274 codec in I2S mode >>> configured to ssp0. >>> >>> Signed-off-by: Guneshwor Singh >>> --- >>> sound/soc/intel/boards/Kconfig | 13 ++ >>> sound/soc/intel/boards/Makefile | 2 + >>> sound/soc/intel/boards/cnl_rt274.c | 250 +++++++++++++++++++++++++++++++++++++ >>> 3 files changed, 265 insertions(+) >>> create mode 100644 sound/soc/intel/boards/cnl_rt274.c >>> >>> diff --git a/sound/soc/intel/boards/Kconfig b/sound/soc/intel/boards/Kconfig >>> index 6f754708a48c..29066f0b744f 100644 >>> --- a/sound/soc/intel/boards/Kconfig >>> +++ b/sound/soc/intel/boards/Kconfig >>> @@ -262,4 +262,17 @@ config SND_SOC_INTEL_KBL_RT5663_RT5514_MAX98927_MACH >>> Say Y if you have such a device. >>> If unsure select "N". >>> +config SND_SOC_INTEL_CNL_RT274_MACH >>> + tristate "ASoC Audio driver for Cannonlake with RT274 I2S mode" >>> + depends on X86 && ACPI && I2C >>> + select SND_SOC_INTEL_SST >>> + depends on SND_SOC_INTEL_SKYLAKE >> this is going to conflict with the fixes I am working on. >> Vinod, can this wait a bit? > Hey Pierre, > > Since you are still working on the fixes, I guess this can sneak in before. > The machine drivers are typically low hanging in terms on complexity so we > can merge this first followed by the rework you are doing. I think that part > will still take a bit to stabilize and cleanup. the update goes out this afternoon, working on it, does this patch really need to 'sneak in'? >