From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Miao Subject: Re: [PATCH] ASoC: pxa-ssp: Don't use SSCR0_SerClkDiv and SSCR0_SCR Date: Sun, 19 Apr 2009 22:01:33 +0800 Message-ID: References: <1239961178-19122-1-git-send-email-philipp.zabel@gmail.com> <20090417102257.GA10992@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from qw-out-1920.google.com (qw-out-1920.google.com [74.125.92.147]) by alsa0.perex.cz (Postfix) with ESMTP id 293B1243FC for ; Sun, 19 Apr 2009 16:01:34 +0200 (CEST) Received: by qw-out-1920.google.com with SMTP id 4so362879qwk.56 for ; Sun, 19 Apr 2009 07:01:33 -0700 (PDT) In-Reply-To: <20090417102257.GA10992@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: alsa-devel@alsa-project.org, Eric Miao , Philipp Zabel List-Id: alsa-devel@alsa-project.org On Fri, Apr 17, 2009 at 6:22 PM, Mark Brown wrote: > On Fri, Apr 17, 2009 at 11:39:38AM +0200, Philipp Zabel wrote: > >> To me, using ssp_dev seems to be cleaner, as all the places where >> ssp_set_scr is called, we already have an ssp_dev *ssp = priv->dev.ssp >> set up, which allows us to call ssp_set_scr(ssp, ...) instead of >> ssp_set_scr(&priv->dev, ...). Same for ssp_get_scr. > > Yeah, the combination of ssp_dev and ssp_device is icky in general and > largely historical as a result of a partially done transition of the > driver to ssp_device. > I'm working on that clean up. A lot of historical and dependency issues indeed. And the patch looks OK. The condition of cpu_is_pxa25x() might not be necessary though, ssp->type == PXA25x_SSP already implies that and is more specific.