RE: Fixing sound on Asus UX534F / some UX533 models

[Kailang <kailang@realtek.com>]

[-- Attachment #1: Type: text/plain, Size: 7035 bytes --]

Hi Hans,

Please let it a try.

Kailang.

> -----Original Message-----
> From: Hans de Goede <hdegoede@redhat.com>
> Sent: Sunday, July 5, 2020 9:25 PM
> To: Kailang <kailang@realtek.com>; Takashi Iwai <tiwai@suse.de>
> Cc: c <kai.heng.feng@canonical.com>; alsa-devel@alsa-project.org;
> nuno.dias@gmail.com; Maxc[錦榮] <maxc@realtek.com>
> Subject: Re: Fixing sound on Asus UX534F / some UX533 models
> 
> Hi,
> 
> On 7/3/20 4:52 PM, Hans de Goede wrote:
> > Hi,
> >
> > On 6/29/20 7:54 AM, Kailang wrote:
> >> Hi Hans,
> >>
> >> The bellowing was Gediminas Aleknavicius (lektuv) mention. (Launchpad
> >> #173) ==>After running the above commands sound and mic works on both
> built-in and headset with 2.5mm connector. The model is UX533FTC.
> >>
> >> Internal Mic was worked.
> >
> > I see and in (Launchpad #174) there is another confirmation that
> > everything works, this time with an UX534FTC.
> >
> > I also got a report from a user in the Red Hat bugzilla about this:
> >
> > On an UX534F just these 2 commands are enough to make everything work:
> >
> > hda-verb /dev/snd/hwC0D0 0x20 0x500 0xf hda-verb /dev/snd/hwC0D0 0x20
> > 0x400 0x7774
> >
> > I'm not entirely sure if using the other 2 commands you gave me are
> > actively causing problems there, or if they just are not necessary.
> > I've asked the reporter about this.
> >
> > So it looks like some models need just:
> >
> > hda-verb /dev/snd/hwC0D0 0x20 0x500 0xf hda-verb /dev/snd/hwC0D0 0x20
> > 0x400 0x7774
> >
> > While others need all 4 commands:
> >
> > hda-verb /dev/snd/hwC1D0 0x20 0x500 0xf hda-verb /dev/snd/hwC1D0 0x20
> > 0x400 0x7774 hda-verb /dev/snd/hwC1D0 0x20 0x500 0x45 hda-verb
> > /dev/snd/hwC1D0 0x20 0x400 0x5289
> >
> > Kailang, is that enough to write a kernel patch for this? If not what
> > other info do you need ?
> 
> A quick follow-up on this, one of the reporters of:
> https://bugzilla.kernel.org/show_bug.cgi?id=206289
> 
> Still has a problem with the internal mic not working.
> 
> He has tried both using all 4 of these:
> 
> hda-verb /dev/snd/hwC1D0 0x20 0x500 0xf
> hda-verb /dev/snd/hwC1D0 0x20 0x400 0x7774 hda-verb /dev/snd/hwC1D0
> 0x20 0x500 0x45 hda-verb /dev/snd/hwC1D0 0x20 0x400 0x5289
> 
> As well as just using:
> 
> hda-verb /dev/snd/hwC1D0 0x20 0x500 0xf
> hda-verb /dev/snd/hwC1D0 0x20 0x400 0x7774
> 
> Which some users report is enough for them.
> His exact modelis "UX533FTC-A8221R"
> 
> Still the 2 / 4 commands (depending on the exact model) do help for various
> other users/models so it would be good to get these added as fixups to the
> kernel.
> 
> The specific model with the internal-mic issue will need further examination.
> 
> Regards,
> 
> Hans
> 
> 
> 
> >>> -----Original Message-----
> >>> From: Hans de Goede <hdegoede@redhat.com>
> >>> Sent: Wednesday, June 24, 2020 9:19 PM
> >>> To: Kailang <kailang@realtek.com>; Takashi Iwai <tiwai@suse.de>
> >>> Cc: c <kai.heng.feng@canonical.com>; alsa-devel@alsa-project.org;
> >>> nuno.dias@gmail.com
> >>> Subject: Re: Fixing sound on Asus UX534F / some UX533 models
> >>>
> >>> Hi,
> >>>
> >>> On 6/23/20 12:02 PM, Hans de Goede wrote:
> >>>> Hi,
> >>>>
> >>>> On 6/4/20 8:49 AM, Kailang wrote:
> >>>>> Hi Hans de Goede,
> >>>>>
> >>>>> Please test below.
> >>>>>
> >>>>> hda-verb /dev/snd/hwC0D0 0x20 0x500 0xf hda-verb /dev/snd/hwC0D0
> >>> 0x20
> >>>>> 0x400 0x7774 hda-verb /dev/snd/hwC0D0 0x20 0x500 0x45 hda-verb
> >>>>> /dev/snd/hwC0D0 0x20 0x400 0x5289
> >>>>>
> >>>>> I think Headset Mic will work.
> >>>>
> >>>> Thank you, and sorry for being somewhat slow to respond.
> >>>>
> >>>> I do not have access to the affected hardware myself.
> >>>>
> >>>> I've asked users who have reported bugs about this to test these
> >>>> setting and report back in the following bug-reports:
> >>>>
> >>>> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1850439
> >>>> https://bugzilla.kernel.org/show_bug.cgi?id=206289
> >>>> https://bugzilla.redhat.com/show_bug.cgi?id=1834751
> >>>>
> >>>> I will follow-up when I have heard back from the bug-reporters.
> >>>
> >>> Ok, I've gotten the first feedback. I ve asked the users to test the
> >>> following after running the 4 suggested hda-verb commands:
> >>>
> >>> 1. Speakers
> >>> 2. Headphones output
> >>> 3. Internal mic.
> >>> 4. Headset mic. (using a phone headset with builtin mic with a
> >>> single T-R-R-S
> >>> connector)
> >>>
> >>> I've got feedback from a user with a UX533FTC-A8221R laptop:
> >>>
> >>> 1. Speakers: works
> >>> 2. Headphones output: works
> >>> 3. Internal mic: doesn't work
> >>> 4. Headset mic: works
> >>>
> >>> So things are looking ok, but we still have some work to do to get
> >>> the internal mic to work.
> >>>
> >>> Kailang do you have any suggestions for getting the internal mic to work?
> >>>
> >>> Regards,
> >>>
> >>> Hans
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>>>> -----Original Message-----
> >>>>>> From: Takashi Iwai <tiwai@suse.de>
> >>>>>> Sent: Tuesday, June 2, 2020 8:42 PM
> >>>>>> To: Hans de Goede <hdegoede@redhat.com>
> >>>>>> Cc: Kailang <kailang@realtek.com>; c
> >>>>>> <kai.heng.feng@canonical.com>; alsa-devel@alsa-project.org;
> >>>>>> nuno.dias@gmail.com
> >>>>>> Subject: Re: Fixing sound on Asus UX534F / some UX533 models
> >>>>>>
> >>>>>> On Tue, 02 Jun 2020 11:51:49 +0200, Hans de Goede wrote:
> >>>>>>>
> >>>>>>> Hi Kai-Heng Feng, Takashi,
> >>>>>>>
> >>>>>>> I see that you are on the notification list for this bug:
> >>>>>>> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1850439
> >>>>>>>
> >>>>>>> So you may have already seen this. Some owners of affected
> >>>>>>> laptops (which have non working speakers / headphone output
> >>>>>>> atm), have done some heroic debugging work and come up with a
> >>>>>>> set of
> >>>>>>> 2 hda-verb commands which fix this.
> >>>>>>>
> >>>>>>> I'm not all that familiar with writing hda quirks, so I was
> >>>>>>> hoping that one of you 2 can come up with a patch to fix this at
> >>>>>>> the kernel level.
> >>>>>>>
> >>>>>>> This would also resolve these 2 bugs, which I believe are the
> >>>>>>> same bug
> >>>>>>> really:
> >>>>>>>
> >>>>>>> https://bugzilla.kernel.org/show_bug.cgi?id=206289
> >>>>>>> https://bugzilla.redhat.com/show_bug.cgi?id=1834751
> >>>>>>
> >>>>>> Adding verbs are trivial and it can be done even without patching
> >>>>>> kernel but providing by a patch via patch module option of
> >>>>>> snd-hda-intel
> >>> driver.
> >>>>>>
> >>>>>> But, before moving forward, I'd like to confirm about the
> >>>>>> correctness (and the
> >>>>>> safeness) of those verbs.
> >>>>>>
> >>>>>> Kailang, could you check the COEF verbs mentioned in the bug
> >>>>>> entry
> >>> above?
> >>>>>>
> >>>>>>
> >>>>>> thanks,
> >>>>>>
> >>>>>> Takashi
> >>>>>>
> >>>>>> ------Please consider the environment before printing this e-mail.
> >>>>>
> >>


[-- Attachment #2: 0000-asus-ux533-ux534.patch --]
[-- Type: application/octet-stream, Size: 755 bytes --]

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index ad43812d63b5..393005dd513b 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7114,7 +7114,7 @@ static const struct hda_fixup alc269_fixups[] = {
 			{ }
 		},
 		.chained = true,
-		.chain_id = ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC
+		.chain_id = ALC269_FIXUP_HEADSET_MIC
 	},
 	[ALC294_FIXUP_ASUS_SPK] = {
 		.type = HDA_FIXUP_VERBS,
@@ -7122,6 +7122,8 @@ static const struct hda_fixup alc269_fixups[] = {
 			/* Set EAPD high */
 			{ 0x20, AC_VERB_SET_COEF_INDEX, 0x40 },
 			{ 0x20, AC_VERB_SET_PROC_COEF, 0x8800 },
+			{ 0x20, AC_VERB_SET_COEF_INDEX, 0x0f },
+			{ 0x20, AC_VERB_SET_PROC_COEF, 0x7774 },
 			{ }
 		},
 		.chained = true,