Re: [PATCH RESEND 0/2] ASoC: Intel: kbl: update dmic fixup params

Re: [PATCH RESEND 0/2] ASoC: Intel: kbl: update dmic fixup params

[Vinod Koul]

On Wed, Nov 15, 2017 at 03:37:41PM +0530, Naveen Manohar wrote:
> Hi Mark,
> 
> These are resend of an already acked patch series.
> I posted it a week ago but there has been update on the base branch.
> I want to resend these. Kindly review and merge.
> 
> Update dmic fixup params to always expose QUAD channel capture device,
> enabling User-space to control channel count.
> Assign min and max channel only based on input hw_params.
> And removes choosing the channel count based on pdata. 

Acked-By: Vinod Koul <vinod.koul@intel.com>

> Naveen Manohar (2):
>   ASoC: Intel: kbl: Remove option of choosing CH count based on pdata
>   ASoC: Intel: kbl: update dmic fixup params
> 
>  sound/soc/intel/boards/kbl_rt5663_max98927.c | 44 +++++++++-------------------
>  1 file changed, 14 insertions(+), 30 deletions(-)
> 
> -- 
> 1.9.1
> 

-- 
~Vinod

Re: [PATCH RESEND 1/2] ASoC: Intel: kbl: Remove option of choosing CH count based on pdata

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 495 bytes --]

On Wed, Nov 15, 2017 at 03:37:42PM +0530, Naveen Manohar wrote:
> Remove option of choosing channel count based on pdata for
> kbl_rt5663_max98927 machine driver.
> As User-space expects 4ch DMIC data and uses channel-map in ucm to
> figure-out the desired channel to use, Hence removing driver change
> to allow choosing channels.

To repeat my previous question which I don't seem to see a response to:

| Which userspace and are you sure there are no boards that only have two
| of the mics?

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: [PATCH RESEND 1/2] ASoC: Intel: kbl: Remove option of choosing CH count based on pdata

[Vinod Koul]

On Wed, Nov 29, 2017 at 12:33:14PM +0000, Mark Brown wrote:
> On Wed, Nov 15, 2017 at 03:37:42PM +0530, Naveen Manohar wrote:
> > Remove option of choosing channel count based on pdata for
> > kbl_rt5663_max98927 machine driver.
> > As User-space expects 4ch DMIC data and uses channel-map in ucm to
> > figure-out the desired channel to use, Hence removing driver change
> > to allow choosing channels.
> 
> To repeat my previous question which I don't seem to see a response to:
> 
> | Which userspace and are you sure there are no boards that only have two
> | of the mics?

I am not sure why Naveen didn't respond, I will ask around.

FWIW the userspace in question is CRAS. CRAS wants to manage MICs and would
*know* how many MICs are on the board and would work with PCM data
accordingly...

-- 
~Vinod

Re: [alsa-devel] [PATCH RESEND 1/2] ASoC: Intel: kbl: Remove option of choosing CH count based on pdata

[Naveen M]

On Thu, Nov 30, 2017 at 09:32:08AM +0530, Vinod Koul wrote:
> On Wed, Nov 29, 2017 at 12:33:14PM +0000, Mark Brown wrote:
> > On Wed, Nov 15, 2017 at 03:37:42PM +0530, Naveen Manohar wrote:
> > > Remove option of choosing channel count based on pdata for
> > > kbl_rt5663_max98927 machine driver.
> > > As User-space expects 4ch DMIC data and uses channel-map in ucm to
> > > figure-out the desired channel to use, Hence removing driver change
> > > to allow choosing channels.
> > 
> > To repeat my previous question which I don't seem to see a response to:
> > 
> > | Which userspace and are you sure there are no boards that only have two
> > | of the mics?
> 
> I am not sure why Naveen didn't respond, I will ask around.
> 
My Bad, my apologies to Mark.
I did try replying but message wasn't sent from my outbox which I'm noticing
today after vinod's mail to Mark.
Sorry about missing this, it's due to mutt configuration in linux that got
corrupted recently in my work-mac, making my replies for patches un-sent.

Regarding the Query:
As Vinod mentioned, I'm working on Chrome OS user-space stack that uses
customized audio server "CRAS".
These patches are verified on a board that has only 2 dmics.

Giving the control to CRAS, enables to select the desired dmic using
channel-map configuration in user-space.
Ex:Rear/Front mic selection for World & Front facing camera scenario 

> FWIW the userspace in question is CRAS. CRAS wants to manage MICs and would

> *know* how many MICs are on the board and would work with PCM data
> accordingly...
> 
> -- 
> ~Vinod

-- 
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH RESEND 1/2] ASoC: Intel: kbl: Remove option of choosing CH count based on pdata

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 703 bytes --]

On Thu, Nov 30, 2017 at 11:44:43AM +0530, Naveen M wrote:

> Regarding the Query:
> As Vinod mentioned, I'm working on Chrome OS user-space stack that uses
> customized audio server "CRAS".
> These patches are verified on a board that has only 2 dmics.
> 
> Giving the control to CRAS, enables to select the desired dmic using
> channel-map configuration in user-space.
> Ex:Rear/Front mic selection for World & Front facing camera scenario 

People do run non-ChromeOS installs on their Chromebooks so we can't
just assume that there's nobody out there with a regular distro on this
hardware - a user like this reported the problems with the ABI for
topology files breaking for example.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: [PATCH RESEND 1/2] ASoC: Intel: kbl: Remove option of choosing CH count based on pdata

[Pierre-Louis Bossart]

On 11/30/17 5:15 AM, Mark Brown wrote:
> On Thu, Nov 30, 2017 at 11:44:43AM +0530, Naveen M wrote:
> 
>> Regarding the Query:
>> As Vinod mentioned, I'm working on Chrome OS user-space stack that uses
>> customized audio server "CRAS".
>> These patches are verified on a board that has only 2 dmics.
>>
>> Giving the control to CRAS, enables to select the desired dmic using
>> channel-map configuration in user-space.
>> Ex:Rear/Front mic selection for World & Front facing camera scenario
> 
> People do run non-ChromeOS installs on their Chromebooks so we can't
> just assume that there's nobody out there with a regular distro on this
> hardware - a user like this reported the problems with the ABI for
> topology files breaking for example.

Valid point indeed.

Re: [PATCH RESEND 1/2] ASoC: Intel: kbl: Remove option of choosing CH count based on pdata

[M, Naveen]

> -----Original Message-----
> From: Mark Brown [mailto:broonie@kernel.org]
> Sent: Thursday, November 30, 2017 4:45 PM
> To: M, Naveen <naveen.m@intel.com>
> Cc: Koul, Vinod <vinod.koul@intel.com>; alsa-devel@alsa-project.org;
> Bossart, Pierre-louis <pierre-louis.bossart@intel.com>; Prusty, Subhransu S
> <subhransu.s.prusty@intel.com>
> Subject: Re: [PATCH RESEND 1/2] ASoC: Intel: kbl: Remove option of choosing
> CH count based on pdata
> 
> On Thu, Nov 30, 2017 at 11:44:43AM +0530, Naveen M wrote:
> 
> > Regarding the Query:
> > As Vinod mentioned, I'm working on Chrome OS user-space stack that
> > uses customized audio server "CRAS".
> > These patches are verified on a board that has only 2 dmics.
> >
> > Giving the control to CRAS, enables to select the desired dmic using
> > channel-map configuration in user-space.
> > Ex:Rear/Front mic selection for World & Front facing camera scenario
> 
> People do run non-ChromeOS installs on their Chromebooks so we can't just
> assume that there's nobody out there with a regular distro on this hardware -
> a user like this reported the problems with the ABI for topology files breaking
> for example.
Understood the point,
shall discuss and work internally with team and reply back. Thanks

Re: [PATCH RESEND 1/2] ASoC: Intel: kbl: Remove option of choosing CH count based on pdata

[Naveen M]

On Thu, Nov 30, 2017 at 09:32:08AM +0530, Vinod Koul wrote:
> On Wed, Nov 29, 2017 at 12:33:14PM +0000, Mark Brown wrote:
> > On Wed, Nov 15, 2017 at 03:37:42PM +0530, Naveen Manohar wrote:
> > > Remove option of choosing channel count based on pdata for
> > > kbl_rt5663_max98927 machine driver.
> > > As User-space expects 4ch DMIC data and uses channel-map in ucm to
> > > figure-out the desired channel to use, Hence removing driver change
> > > to allow choosing channels.
> > 
> > To repeat my previous question which I don't seem to see a response to:
> > 
> > | Which userspace and are you sure there are no boards that only have two
> > | of the mics?
> 
> I am not sure why Naveen didn't respond, I will ask around.
> 
My Bad, my apologies to Mark.
I did try replying but message wasn't sent from my outbox which I'm noticing
today after vinod's mail to Mark.
Sorry about missing this, it's due to mutt configuration in linux that got
corrupted recently in my work-mac, making my replies for patches un-sent.

Regarding the Query:
As Vinod mentioned, I'm working on Chrome OS user-space stack that uses
customized audio server "CRAS".
These patches are verified on a board that has only 2 dmics.

Giving the control to CRAS, enables to select the desired dmic using
channel-map configuration in user-space.
Ex:Rear/Front mic selection for World & Front facing camera scenario 

> FWIW the userspace in question is CRAS. CRAS wants to manage MICs and would

> *know* how many MICs are on the board and would work with PCM data
> accordingly...
> 
> -- 
> ~Vinod

--