From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Bard Liao <bardliao@realtek.com>, Mark Brown <broonie@kernel.org>,
Hans de Goede <hdegoede@redhat.com>
Cc: Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Oder Chiou <oder_chiou@realtek.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Carlo Caione <carlo@endlessm.com>
Subject: Re: [PATCH 1/6] ASoC: rt5651: Add IN3 Boost volume control
Date: Thu, 19 Jul 2018 20:40:09 -0500 [thread overview]
Message-ID: <f38e30f0-182b-484e-8de1-a9fd0db4663c@linux.intel.com> (raw)
In-Reply-To: <ABFD875FF5FB574BA706497D987D48D7028430F3@RTITMBSV02.realtek.com.tw>
On 07/19/2018 08:31 PM, Bard Liao wrote:
>> -----Original Message-----
>> From: Mark Brown [mailto:broonie@kernel.org]
>> Sent: Thursday, July 19, 2018 11:03 PM
>> To: Hans de Goede
>> Cc: Liam Girdwood; Bard Liao; Oder Chiou; Pierre-Louis Bossart; Carlo Caione;
>> alsa-devel@alsa-project.org
>> Subject: Re: [PATCH 1/6] ASoC: rt5651: Add IN3 Boost volume control
>>
>> On Wed, Jul 18, 2018 at 10:55:37PM +0200, Hans de Goede wrote:
>>
>>> + /* IN1/IN2/IN3 Control */
>>> SOC_SINGLE_TLV("IN1 Boost", RT5651_IN1_IN2,
>>> RT5651_BST_SFT1, 8, 0, bst_tlv),
>>> SOC_SINGLE_TLV("IN2 Boost", RT5651_IN1_IN2,
>>> RT5651_BST_SFT2, 8, 0, bst_tlv),
>>> + SOC_SINGLE_TLV("IN3 Boost", RT5651_IN3,
>>> + RT5651_BST_SFT1, 8, 0, bst_tlv),
>> These should all have Volume added to the name however that's a
>> preexisting bug so not a blocker on this.
> I will add "Volume" to the name for all of them.
isn't this going to break userspace configs if we change the name of
controls?
next prev parent reply other threads:[~2018-07-20 1:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 20:55 [PATCH 0/6] ASoC: rt5651: Various fixes and quirks Hans de Goede
2018-07-18 20:55 ` [PATCH 1/6] ASoC: rt5651: Add IN3 Boost volume control Hans de Goede
2018-07-19 15:02 ` Mark Brown
2018-07-20 1:31 ` Bard Liao
2018-07-20 1:40 ` Pierre-Louis Bossart [this message]
2018-07-20 2:53 ` Bard Liao
2018-07-27 12:01 ` Hans de Goede
2018-07-30 1:58 ` Bard Liao
2018-07-30 8:28 ` Mark Brown
2018-07-19 16:57 ` Applied "ASoC: rt5651: Add IN3 Boost volume control" to the asoc tree Mark Brown
2018-07-18 20:55 ` [PATCH 2/6] ASoC: Intel: bytcr_rt5651: Fix using the wrong GPIO for the ext-amp on some boards Hans de Goede
2018-07-19 16:57 ` Applied "ASoC: Intel: bytcr_rt5651: Fix using the wrong GPIO for the ext-amp on some boards" to the asoc tree Mark Brown
2018-07-18 20:55 ` [PATCH 3/6] ASoC: Intel: bytcr_rt5651: Set OVCD limit for VIOS LTH17 to 2000uA Hans de Goede
2018-07-19 16:57 ` Applied "ASoC: Intel: bytcr_rt5651: Set OVCD limit for VIOS LTH17 to 2000uA" to the asoc tree Mark Brown
2018-07-18 20:55 ` [PATCH 4/6] ASoC: Intel: bytcr_rt5651: Add IN2 input mapping Hans de Goede
2018-07-18 21:20 ` Pierre-Louis Bossart
2018-07-19 11:37 ` Hans de Goede
2018-07-19 13:08 ` Pierre-Louis Bossart
2018-07-19 16:57 ` Applied "ASoC: Intel: bytcr_rt5651: Add IN2 input mapping" to the asoc tree Mark Brown
2018-07-18 20:55 ` [PATCH 5/6] ASoC: Intel: bytcr_rt5651: Add mono speaker quirk Hans de Goede
2018-07-19 16:56 ` Applied "ASoC: Intel: bytcr_rt5651: Add mono speaker quirk" to the asoc tree Mark Brown
2018-07-18 20:55 ` [PATCH 6/6] ASoC: Intel: bytcr_rt5651: Add quirk table entries for various devices Hans de Goede
2018-07-19 16:56 ` Applied "ASoC: Intel: bytcr_rt5651: Add quirk table entries for various devices" to the asoc tree Mark Brown
2018-12-24 14:15 ` [PATCH 0/6] ASoC: rt5651: Various fixes and quirks Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f38e30f0-182b-484e-8de1-a9fd0db4663c@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=broonie@kernel.org \
--cc=carlo@endlessm.com \
--cc=hdegoede@redhat.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=oder_chiou@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox