Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Jenny TC <jenny.tc@intel.com>,
	alsa-devel@alsa-project.org, broonie@kernel.org,
	yang.jie@linux.intel.com
Cc: harshapriya.n@intel.com
Subject: Re: [PATCH 2/2] ASoC: Intel: Common: Enable kbl_da7219_max98373 ACPI match
Date: Tue, 22 Jan 2019 13:51:03 -0600	[thread overview]
Message-ID: <f3f06348-7229-83f9-d927-cbb2f3a55de8@linux.intel.com> (raw)
In-Reply-To: <1548096190-24584-3-git-send-email-jenny.tc@intel.com>


> diff --git a/sound/soc/intel/common/soc-acpi-intel-kbl-match.c b/sound/soc/intel/common/soc-acpi-intel-kbl-match.c
> index e6fa6f4..cab841d 100644
> --- a/sound/soc/intel/common/soc-acpi-intel-kbl-match.c
> +++ b/sound/soc/intel/common/soc-acpi-intel-kbl-match.c
> @@ -37,6 +37,11 @@
>   	.codecs = {"MX98927"}
>   };
>   
> +static struct snd_soc_acpi_codecs kbl_7219_98373_codecs = {
> +	.num_codecs = 1,
> +	.codecs = {"MX98373"}
> +};
> +
>   struct snd_soc_acpi_mach snd_soc_acpi_intel_kbl_machines[] = {
>   	{
>   		.id = "INT343A",
> @@ -106,6 +111,14 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_kbl_machines[] = {
>   		.drv_name = "kbl_rt5660",
>   		.fw_filename = "intel/dsp_fw_kbl.bin",
>   	},
> +	{
> +		.id = "DLGS7219",
> +		.drv_name = "kbl_da7219_max98373",
> +		.fw_filename = "intel/dsp_fw_kbl.bin",
> +		.machine_quirk = snd_soc_acpi_codec_list,
> +		.quirk_data = &kbl_7219_98373_codecs,
> +		.pdata = &skl_dmic_data

You provided a machine driver that can work with or without DA7219, so 
can you please clarify how the model without DA7219 is handled if you 
use the DA7219 as a primary key for the ACPI search? My current 
understanding is that the driver name "kbl_max98373" will never be used.

      reply	other threads:[~2019-01-22 19:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-21 18:43 [PATCH 0/2] ASoC: Intel: Add support for kbl_da7219_max9837 machine driver Jenny TC
2019-01-21 18:43 ` [PATCH] ASoC: Intel: Boards: Add KBL Dialog Maxim98373 I2S " Jenny TC
2019-01-22 19:45   ` Pierre-Louis Bossart
2019-01-26  2:34     ` Tc, Jenny
2019-01-21 18:43 ` [PATCH 2/2] ASoC: Intel: Common: Enable kbl_da7219_max98373 ACPI match Jenny TC
2019-01-22 19:51   ` Pierre-Louis Bossart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f3f06348-7229-83f9-d927-cbb2f3a55de8@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=harshapriya.n@intel.com \
    --cc=jenny.tc@intel.com \
    --cc=yang.jie@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox