alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: b_lkasam@codeaurora.org
To: alsa-devel@alsa-project.org
Cc: lkasam@qti.qualcomm.com, mangeshk@qti.qualcomm.com
Subject: ALSA: Soc_compress open file node allows more than once
Date: Thu, 23 Nov 2017 18:48:30 +0530	[thread overview]
Message-ID: <f469eb3a04f49f7b5603572546852685@codeaurora.org> (raw)

Hi ALSA team,
This is regarding compress offload framework file operations wrt open 
system call.

For open call to this driver currently allows for same node more than 
once.

This may result in memleak issues or data corruption if same node in use 
by multiple instances.

can we have restriction to avoid open of same node using some refcount?

we can either have refcount under compr->private_data and cross check in 
below function before proceeding.
static int snd_compr_open(struct inode *inode, struct file *f)

Please suggest accordingly.

Thanks
Laxminath Kasam,
Qualcomm.

             reply	other threads:[~2017-11-23 13:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-23 13:18 b_lkasam [this message]
2017-11-23 13:41 ` ALSA: Soc_compress open file node allows more than once Takashi Iwai
2017-11-27  5:50   ` Vinod Koul
2017-12-28  6:35     ` b_lkasam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f469eb3a04f49f7b5603572546852685@codeaurora.org \
    --to=b_lkasam@codeaurora.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=lkasam@qti.qualcomm.com \
    --cc=mangeshk@qti.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).