From: Jon Hunter <jonathanh@nvidia.com>
To: Ben Dooks <ben.dooks@codethink.co.uk>,
<linux-tegra@vger.kernel.org>, <alsa-devel@alsa-project.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>
Cc: linux-kernel@lists.codethink.co.uk,
Edward Cragg <edward.cragg@codethink.co.uk>
Subject: Re: [alsa-devel] [PATCH v3 1/7] ASoC: tegra: add a TDM configuration callback
Date: Tue, 1 Oct 2019 14:37:55 +0100 [thread overview]
Message-ID: <f4e68563-e059-9f86-7340-de71c59d9a90@nvidia.com> (raw)
In-Reply-To: <85bb5ec6-8928-e4ea-8ca5-3ce1afcc4324@codethink.co.uk>
On 01/10/2019 12:00, Ben Dooks wrote:
> On 30/09/2019 21:46, Jon Hunter wrote:
>>
>> On 30/09/2019 17:51, Ben Dooks wrote:
>>> From: Edward Cragg <edward.cragg@codethink.co.uk>
>>>
>>> Add a callback to configure TDM settings for the Tegra30 I2S ASoC
>>> 'platform'
>>> driver.
>>>
>>> Signed-off-by: Edward Cragg <edward.cragg@codethink.co.uk>
>>> [ben.dooks@codethink.co.uk: merge fix for power management]
>>> [ben.dooks@codethink.co.uk: add review change for fsync of 1 clock]
>>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
>>> ---
>>> sound/soc/tegra/tegra30_i2s.c | 33 +++++++++++++++++++++++++++++++++
>>> 1 file changed, 33 insertions(+)
>>>
>>> diff --git a/sound/soc/tegra/tegra30_i2s.c
>>> b/sound/soc/tegra/tegra30_i2s.c
>>> index ac6983c6bd72..7f9ef6abeae2 100644
>>> --- a/sound/soc/tegra/tegra30_i2s.c
>>> +++ b/sound/soc/tegra/tegra30_i2s.c
>>> @@ -254,6 +254,38 @@ static int tegra30_i2s_trigger(struct
>>> snd_pcm_substream *substream, int cmd,
>>> return 0;
>>> }
>>> +/*
>>> + * Set up TDM
>>> + */
>>> +static int tegra30_i2s_set_tdm(struct snd_soc_dai *dai,
>>> + unsigned int tx_mask, unsigned int rx_mask,
>>> + int slots, int slot_width)
>>> +{
>>> + struct tegra30_i2s *i2s = snd_soc_dai_get_drvdata(dai);
>>> + unsigned int mask, val;
>>> +
>>> + dev_dbg(dai->dev, "%s: txmask=0x%08x rxmask=0x%08x slots=%d
>>> width=%d\n",
>>> + __func__, tx_mask, rx_mask, slots, slot_width);
>>> +
>>> + /* Set up slots and tx/rx masks */
>>> + mask = TEGRA30_I2S_SLOT_CTRL_TOTAL_SLOTS_MASK |
>>> + TEGRA30_I2S_SLOT_CTRL_RX_SLOT_ENABLES_MASK |
>>> + TEGRA30_I2S_SLOT_CTRL_TX_SLOT_ENABLES_MASK;
>>> +
>>> + val = (tx_mask << TEGRA30_I2S_SLOT_CTRL_TX_SLOT_ENABLES_SHIFT) |
>>> + (rx_mask << TEGRA30_I2S_SLOT_CTRL_RX_SLOT_ENABLES_SHIFT) |
>>> + ((slots - 1) << TEGRA30_I2S_SLOT_CTRL_TOTAL_SLOTS_SHIFT);
>>
>> I am not sure why this keeps changing. Why not set to 1 always?
>
> This is the total number of slots, not the width of the fsync
> which has been changed to 1 below this.
Ah yes indeed. Sorry, should have waited until this morning to look at
this! Jon
--
nvpublic
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-10-01 13:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 16:51 [alsa-devel] tegra30 tdm audio support Ben Dooks
2019-09-30 16:51 ` [alsa-devel] [PATCH v3 1/7] ASoC: tegra: add a TDM configuration callback Ben Dooks
2019-09-30 20:46 ` Jon Hunter
2019-10-01 11:00 ` Ben Dooks
2019-10-01 13:37 ` Jon Hunter [this message]
2019-10-01 13:40 ` Jon Hunter
2019-10-01 13:56 ` Ben Dooks
2019-10-01 17:03 ` Ben Dooks
2019-09-30 16:51 ` [alsa-devel] [PATCH v3 2/7] ASoC: tegra: Allow 24bit and 32bit samples Ben Dooks
2019-09-30 16:51 ` [alsa-devel] [PATCH v3 3/7] ASoC: tegra: i2s: Add support for more than 2 channels Ben Dooks
2019-09-30 16:51 ` [alsa-devel] [PATCH v3 4/7] ASoC: tegra: disable rx_fifo after disable stream Ben Dooks
2019-09-30 16:51 ` [alsa-devel] [PATCH v3 5/7] ASoC: tegra: set i2s_offset to 0 for tdm Ben Dooks
2019-09-30 20:52 ` Jon Hunter
2019-10-01 11:09 ` Ben Dooks
2019-10-01 11:44 ` Mark Brown
2019-09-30 16:51 ` [alsa-devel] [PATCH v3 6/7] ASoC: tegra: config fifos on hw_param changes Ben Dooks
2019-09-30 21:08 ` Jon Hunter
2019-10-04 17:03 ` Ben Dooks
2019-10-07 8:08 ` Jon Hunter
2019-09-30 16:51 ` [alsa-devel] [PATCH v3 7/7] ASoC: tegra: take packing settings from the audio cif_config Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4e68563-e059-9f86-7340-de71c59d9a90@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=alsa-devel@alsa-project.org \
--cc=ben.dooks@codethink.co.uk \
--cc=broonie@kernel.org \
--cc=edward.cragg@codethink.co.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-tegra@vger.kernel.org \
--cc=perex@perex.cz \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox