From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8EEA1C3DA4A for ; Tue, 20 Aug 2024 14:30:49 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id EA8F320E; Tue, 20 Aug 2024 16:30:37 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz EA8F320E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1724164248; bh=27VQnEMdnqOcGlF7LNJhoGhfIvxG5khxXm1G5k4+TBs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=Tf+mYOwaSUAo65NkzSMbNoVAJhoFzV3wvWuQY4jUJNzlDa9sXE/Qpzd2Ms6ggc+bW mMaOjztkaLZ3GxuaVv170fva7fTwVeJMdGP5wky7a771T7AGhwnKTijzuZFt8Bh24N OCR7y0gvw9JrA6DNF95wVxWk9KCBp/5Zq8xOC/cY= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 206F3F805D6; Tue, 20 Aug 2024 16:29:46 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 696BDF805E2; Tue, 20 Aug 2024 16:29:46 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 03B7AF8049C; Tue, 20 Aug 2024 11:40:21 +0200 (CEST) Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id F2E36F8025E for ; Tue, 20 Aug 2024 11:37:16 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz F2E36F8025E Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=ALSiNT2y Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 197BFCE0B96; Tue, 20 Aug 2024 09:37:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE989C4AF0F; Tue, 20 Aug 2024 09:37:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724146631; bh=27VQnEMdnqOcGlF7LNJhoGhfIvxG5khxXm1G5k4+TBs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ALSiNT2yd7HBz2jpgfAZUiv/N9akqjpIfqYDV2dGBAQxcGOvvtNzRQw/6ZGrTz+7n od3kHyuyX1kOEGTcaPT5TBPArVDBKT2OAm/BaNLKVmpYkoBFHidxSRVXawekbFZpJv zXtPypbCl/B2PA1Xp/d1hFS+PHO2+AmFL3ycIO8Q47dFIc0Gd+DWH8MYUeLjU6fhD5 kA2+Yfz5UOIJcK09FP4b+aSPlaqt/MeORAPj/8L9MZiyRXWwPovpTuiuf1yvMG38QM LcjfZwayQWMBxQ+awv7SpTKVAqBzlig1Wk1dAVwbyS/VPh+hU7Pen00cVkbw1q35d7 jsBuwuX10CFHg== Message-ID: Date: Tue, 20 Aug 2024 11:37:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/8] ASoC: qcom: apq8016_sbc.c: Add Quinary support To: Adam Skladowski , Srinivas Kandagatla , Banajit Goswami , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , Stephan Gerhold Cc: alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Vladimir Lypak References: <20240731-msm8953-msm8976-asoc-v3-0-163f23c3a28d@gmail.com> <20240731-msm8953-msm8976-asoc-v3-1-163f23c3a28d@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20240731-msm8953-msm8976-asoc-v3-1-163f23c3a28d@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-MailFrom: konradybcio@kernel.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1 Message-ID-Hash: HU7WSLRORZNSSDRQJTUOILEDA3GHUXSI X-Message-ID-Hash: HU7WSLRORZNSSDRQJTUOILEDA3GHUXSI X-Mailman-Approved-At: Tue, 20 Aug 2024 14:26:50 +0000 X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 31.07.2024 5:25 PM, Adam Skladowski wrote: > From: Vladimir Lypak > > Add support for configuring Quinary Mi2S interface > it will be used on MSM8953 and MSM8976 platform. > > Signed-off-by: Vladimir Lypak > [Adam: Split from MSM8953 support patch,add msg] > Signed-off-by: Adam Skladowski > --- > sound/soc/qcom/apq8016_sbc.c | 17 ++++++++++++++++- > 1 file changed, 16 insertions(+), 1 deletion(-) > > diff --git a/sound/soc/qcom/apq8016_sbc.c b/sound/soc/qcom/apq8016_sbc.c > index 3023cf180a75..5a29adbd3f82 100644 > --- a/sound/soc/qcom/apq8016_sbc.c > +++ b/sound/soc/qcom/apq8016_sbc.c > @@ -20,12 +20,13 @@ > #include "common.h" > #include "qdsp6/q6afe.h" > > -#define MI2S_COUNT (MI2S_QUATERNARY + 1) > +#define MI2S_COUNT (MI2S_QUINARY + 1) > > struct apq8016_sbc_data { > struct snd_soc_card card; > void __iomem *mic_iomux; > void __iomem *spkr_iomux; > + void __iomem *quin_iomux; > struct snd_soc_jack jack; > bool jack_setup; > int mi2s_clk_count[MI2S_COUNT]; > @@ -86,6 +87,12 @@ static int apq8016_dai_init(struct snd_soc_pcm_runtime *rtd, int mi2s) > SPKR_CTL_TLMM_DATA1_EN | SPKR_CTL_TLMM_WS_OUT_SEL_SEC | > SPKR_CTL_TLMM_WS_EN_SEL_SEC, pdata->spkr_iomux); > break; > + case MI2S_QUINARY: > + /* Configure Quinary MI2S */ > + if (!pdata->quin_iomux) > + return -ENOENT; > + writel(readl(pdata->quin_iomux) | 0x01, pdata->quin_iomux); I'm nitpicking, but 0x01 here is BIT(0) Acked-by: Konrad Dybcio Konrad