From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org
Cc: Libin Yang <libin.yang@intel.com>,
Mengdong Lin <mengdong.lin@intel.com>,
broonie@kernel.org, Keyon Jie <yang.jie@linux.intel.com>,
liam.r.girdwood@linux.intel.com
Subject: Re: [PATCH 05/14] ALSA: pci: Remove superfluous snd_pcm_suspend*() calls
Date: Tue, 15 Jan 2019 10:49:56 -0600 [thread overview]
Message-ID: <f675ffaa-9966-a05b-7915-a4a16eefbfcb@linux.intel.com> (raw)
In-Reply-To: <20190115162155.6308-6-tiwai@suse.de>
> diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c
> index 9f8d59e7e89f..ff6dbed4d3cd 100644
> --- a/sound/pci/hda/hda_codec.c
> +++ b/sound/pci/hda/hda_codec.c
> @@ -2927,8 +2927,6 @@ static int hda_codec_runtime_suspend(struct device *dev)
> unsigned int state;
>
> cancel_delayed_work_sync(&codec->jackpoll_work);
> - list_for_each_entry(pcm, &codec->pcm_list_head, list)
> - snd_pcm_suspend_all(pcm->pcm);
> state = hda_call_codec_suspend(codec);
> if (codec->link_down_at_suspend ||
> (codec_has_clkstop(codec) && codec_has_epss(codec) &&
question: since we now use HDAudio codecs in an ASoC-based
implementation (both with the Skylake and SOF drivers), is this creating
a case where suspend no longer works? I see no suspend support in
sound/soc/codec/hdac_hda.c
I just added a quick trace in the lines being deleted and those lines
were definitively executed.
list_for_each_entry(pcm, &codec->pcm_list_head, list) {
pr_err("plb: suspending pcm\n");
snd_pcm_suspend_all(pcm->pcm);
}
[ 2.516349] plb: suspending pcm
[ 2.516350] plb: suspending pcm
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-01-15 16:49 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 16:21 [PATCH 00/14] ALSA: PCM suspend cleanup Takashi Iwai
2019-01-15 16:21 ` [PATCH 01/14] ALSA: pcm: Suspend streams globally via device type PM ops Takashi Iwai
2019-01-28 18:11 ` Mark Brown
2019-01-15 16:21 ` [PATCH 02/14] ALSA: atiixp: Move PCM suspend/resume code into trigger callback Takashi Iwai
2019-01-15 16:21 ` [PATCH 03/14] ALSA: isa: Remove superfluous snd_pcm_suspend*() calls Takashi Iwai
2019-01-15 16:21 ` [PATCH 04/14] ALSA: drivers: " Takashi Iwai
2019-01-15 16:21 ` [PATCH 05/14] ALSA: pci: " Takashi Iwai
2019-01-15 16:49 ` Pierre-Louis Bossart [this message]
2019-01-15 17:01 ` Takashi Iwai
2019-01-15 20:42 ` Takashi Iwai
2019-01-16 15:50 ` Mark Brown
2019-01-16 15:52 ` Takashi Iwai
2019-01-16 16:32 ` Mark Brown
2019-01-17 15:55 ` Mark Brown
2019-01-17 2:21 ` Pierre-Louis Bossart
2019-01-17 8:39 ` Takashi Iwai
2019-01-28 19:28 ` Pierre-Louis Bossart
2019-01-15 16:21 ` [PATCH 06/14] ALSA: usb: " Takashi Iwai
2019-01-15 16:21 ` [PATCH 07/14] ALSA: x86: " Takashi Iwai
2019-01-15 16:21 ` [PATCH 08/14] ALSA: ppc: " Takashi Iwai
2019-01-15 16:21 ` [PATCH 09/14] ALSA: aoa: " Takashi Iwai
2019-01-15 16:21 ` [PATCH 10/14] ALSA: arm: " Takashi Iwai
2019-01-15 16:21 ` [PATCH 11/14] ALSA: pcmcia: " Takashi Iwai
2019-01-15 16:21 ` [PATCH 12/14] drm: bridge: dw-hdmi: " Takashi Iwai
2019-01-15 16:21 ` [PATCH 13/14] ALSA: doc: Update the description about PCM suspend procedure Takashi Iwai
2019-01-15 16:21 ` [PATCH 14/14] ALSA: pcm: Make snd_pcm_suspend() local static Takashi Iwai
2019-01-17 1:50 ` Yang, Libin
2019-01-17 7:43 ` Takashi Iwai
2019-01-17 14:53 ` Yang, Libin
2019-01-15 16:32 ` [PATCH 00/14] ALSA: PCM suspend cleanup Jaroslav Kysela
2019-01-17 1:47 ` Yang, Libin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f675ffaa-9966-a05b-7915-a4a16eefbfcb@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=libin.yang@intel.com \
--cc=mengdong.lin@intel.com \
--cc=tiwai@suse.de \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).