From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (unknown [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C783C3DA4A for ; Thu, 1 Aug 2024 09:12:58 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id DC6313774; Thu, 1 Aug 2024 11:12:39 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz DC6313774 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1722503569; bh=bWXEw8TFjsKa/Hb4/Eb5rG16j7U/8Z24Kda92N1MJ4I=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=pUfviv/MtOxRNNzzeLeHAut5C8R74OOVe1yUmaijQa5wu4e6G795lbj5T2+qvq1SV Vx7AoOSPMPJOMprc/yzRQr+btDzBEiHAoKsrDYFZTcLoF2vlSEHSXqS4AQCGBM2IoS JvuLzDbeEDuU+3YNl5G6OlRNa9WzYqPBRK5MiQes= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 57835F8007E; Thu, 1 Aug 2024 11:12:16 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id E1BC4F805AD; Thu, 1 Aug 2024 11:12:15 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 65BB9F80580; Thu, 1 Aug 2024 11:12:03 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 56275F8019B for ; Thu, 1 Aug 2024 11:11:55 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 56275F8019B Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=C5sfOjqP DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1722503518; x=1754039518; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=bWXEw8TFjsKa/Hb4/Eb5rG16j7U/8Z24Kda92N1MJ4I=; b=C5sfOjqP2rjl1C1KLk4MpTYqS0UEd9xfzgvev8kbtVybbXDB1g80tP67 +nMrzFyfsvZvahyO28d+3tRshvNAjhVGnmXWGLWLZpdR1ZdZgQIXyTyVF z+OX3zlcPIWB9hkFfAM4pko2SXG3oUV7LqyEHT6JukDYb1dU18SAM0rRn N9PK7upb+ZDYVfMO9p8Hd6iDUAhol+Z1n5Lok+DeI4q32FtmLflOdPFII /uZI3jE3gG8S2e6T44bsoprXSG+jdi63M3QqqUrGusH3rFe19Jyyh56Sd ncinQGPHquiv/MMy7fdnfE2mnPcDTcaXEs2kWUw6ZB5Gq4WUBXlFWrk1f g==; X-CSE-ConnectionGUID: RrhRysN2TVqZRuzEKVp0tA== X-CSE-MsgGUID: ZQWwrCeQRm6BQRJd2qpc8A== X-IronPort-AV: E=McAfee;i="6700,10204,11150"; a="20383381" X-IronPort-AV: E=Sophos;i="6.09,254,1716274800"; d="scan'208";a="20383381" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2024 02:10:59 -0700 X-CSE-ConnectionGUID: wD2mZchpQ2uK+zw06fP8TQ== X-CSE-MsgGUID: 2y4A7VElRRC8qWG3k+0cRQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,254,1716274800"; d="scan'208";a="59089784" Received: from lfiedoro-mobl.ger.corp.intel.com (HELO [10.245.246.220]) ([10.245.246.220]) by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2024 02:10:53 -0700 Message-ID: Date: Thu, 1 Aug 2024 11:10:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v24 00/34] Introduce QC USB SND audio offloading support To: Wesley Cheng , srinivas.kandagatla@linaro.org, mathias.nyman@intel.com, perex@perex.cz, conor+dt@kernel.org, corbet@lwn.net, broonie@kernel.org, lgirdwood@gmail.com, krzk+dt@kernel.org, Thinh.Nguyen@synopsys.com, bgoswami@quicinc.com, tiwai@suse.com, gregkh@linuxfoundation.org, robh@kernel.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-sound@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-doc@vger.kernel.org, alsa-devel@alsa-project.org References: <20240801011730.4797-1-quic_wcheng@quicinc.com> Content-Language: en-US From: Pierre-Louis Bossart In-Reply-To: <20240801011730.4797-1-quic_wcheng@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Message-ID-Hash: H6XFQH5AI352NWBRF4222S3QDYMZNCXC X-Message-ID-Hash: H6XFQH5AI352NWBRF4222S3QDYMZNCXC X-MailFrom: pierre-louis.bossart@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 8/1/24 03:16, Wesley Cheng wrote: > Requesting to see if we can get some Acked-By tags, and merge on usb-next. I find this update a lot easier to review than previous versions, thanks for this. That said, there are still quite a few confusing parts in the documentation and implementation - specifically the get_offload_dev() stuff makes sense at a high-level but the details can be improved a great deal. It's encouraging though, there aren't any major conceptual issues IMHO, it shouldn't be too hard to make the patches clearer/cleaner.