From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B9384C636D6 for ; Thu, 9 Feb 2023 15:25:15 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E7630DF6; Thu, 9 Feb 2023 16:24:22 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E7630DF6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1675956313; bh=u8Vb8/bYrBeWgw+p0XSQUULBRKZVvrASNP/roYXBOOM=; h=Date:Subject:To:References:From:In-Reply-To:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=FIe07MyGGCSBOEI6cXoLnUckaNT1rD82QmGIYhCaYcXc1XCam8q+jiJB6N2+42A0l 3mdK5rMEv0ci0J0WGVxa03Cbsm4RTaCV1k5gTdRvJ8torzoMA5NFalLm5Ue8VqsHP7 Sy/xM9S9b4/2c79vCdFt8FM6uyIZWFPJ7cYv34BA= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 63467F800E4; Thu, 9 Feb 2023 16:23:57 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 44577F800E4; Thu, 9 Feb 2023 16:23:53 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 33CFEF80027 for ; Thu, 9 Feb 2023 16:23:47 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 33CFEF80027 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=DzwBx3LW DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675956230; x=1707492230; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=u8Vb8/bYrBeWgw+p0XSQUULBRKZVvrASNP/roYXBOOM=; b=DzwBx3LWQeU6oWP/rhF9XIYZHRNK3C7L4ITBnlTcnSuQMVY3SBlqjlhV HE1cxzBwrF+JAhBIftZ5Y7QQXiKVooxqwkkMKw2u8GG5rIFdvuw53iXEI S3SfWszIo4d/6kfaUqo+0KLX6MVAG5bWfjaIBmCIDGqgJw6cCH7gEG4Uz prY7SiZf6Ut7Oq6sALZcrKTWklTlk2RdLiYI0FZq2QNdrZDtuk4uFTIMt qiffiDyobvyyYBI65kVy/k+Qv2mXvVh3VJE+XkvOjf1spmfHdUSjkccgr ZXTQf53aBZOa5lR3TJcoyyVkzW/49S+ik5hF7ouqMsSGxllcZ6YstLLKD Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10615"; a="328771482" X-IronPort-AV: E=Sophos;i="5.97,284,1669104000"; d="scan'208";a="328771482" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2023 07:15:04 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10615"; a="913156459" X-IronPort-AV: E=Sophos;i="5.97,284,1669104000"; d="scan'208";a="913156459" Received: from fpastor-mobl4.amr.corp.intel.com (HELO [10.212.74.130]) ([10.212.74.130]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2023 07:15:03 -0800 Message-ID: Date: Thu, 9 Feb 2023 09:15:03 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.7.1 Subject: Re: [PATCH] ALSA: hda: remove redundant variable in snd_hdac_stream_start() To: Mark Brown , Zhang Yiqun References: <20230209121723.14328-1-zhangyiqun@phytium.com.cn> Content-Language: en-US From: Pierre-Louis Bossart In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Message-ID-Hash: J3EFVKTV7FDKCCS4U2AY2VNFOT2KS524 X-Message-ID-Hash: J3EFVKTV7FDKCCS4U2AY2VNFOT2KS524 X-MailFrom: pierre-louis.bossart@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: cezary.rojewski@intel.com, liam.r.girdwood@linux.intel.com, peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com, ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com, tiwai@suse.com, amadeuszx.slawinski@linux.intel.com, kuninori.morimoto.gx@renesas.com, ckeepax@opensource.cirrus.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2/9/23 08:32, Mark Brown wrote: > On Thu, Feb 09, 2023 at 08:17:23PM +0800, Zhang Yiqun wrote: >> This 2nd variables are all set as true in treewide. So I think >> it can be removed for easy understanding. > > Acked-by: Mark Brown Reviewed-by: Pierre-Louis Bossart Btw there's another type of always-true parameter, we have a full_reset parameter that's not used. sound/soc/intel/skylake$ git grep skl_init_chip skl.c:static int skl_init_chip(struct hdac_bus *bus, bool full_reset) skl.c: skl_init_chip(bus, true); skl.c: skl_init_chip(bus, true); skl.c: err = skl_init_chip(bus, true); sound/soc/intel/avs$ git grep init_chip core.c:static bool avs_hdac_bus_init_chip(struct hdac_bus *bus, bool full_reset) core.c: ret = snd_hdac_bus_init_chip(bus, full_reset); core.c: avs_hdac_bus_init_chip(bus, true); core.c: avs_hdac_bus_init_chip(bus, true); core.c: avs_hdac_bus_init_chip(bus, true);