Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Vinod Koul <vinod.koul@intel.com>
Cc: ALSA <alsa-devel@alsa-project.org>,
	tiwai@suse.de, Greg KH <gregkh@linuxfoundation.org>,
	liam.r.girdwood@linux.intel.com, patches.audio@intel.com,
	broonie@kernel.org, Sanyog Kale <sanyog.r.kale@intel.com>
Subject: Re: [PATCH v4 02/13] soundwire: Add support for SoundWire stream management
Date: Mon, 23 Apr 2018 08:25:21 -0500	[thread overview]
Message-ID: <f869e5a4-2651-9ee4-aa3a-6f21eaa15c01@linux.intel.com> (raw)
In-Reply-To: <20180421161756.GP6014@localhost>


>>
>>> +			(stream->params.bps != stream_config->bps)) {
>>> +		dev_err(dev, "bps not matching, stream:%s", stream->name);
>>> +		return -EINVAL;
>>> +	}
>>> +
>>> +	stream->type = stream_config->type;
>>> +	stream->params.rate = stream_config->frame_rate;
>>> +	stream->params.bps = stream_config->bps;
>>> +	if (is_slave)
>>> +		stream->params.ch_count += stream_config->ch_count;
>>
>> Add comment or TODO that this does not work in device-to-device
>> communication. This is a known limitation that needs to be tracked.
> 
> Yes limitation for a feature that we dont support yet. So i dont think we
> need to do anything atm for this. When the support for device-to-device
> shows up, that would update this and other conditions valid only for specific
> cases.

so if you don't support it yet, add a comment that this will have to be 
modified. This is all I am asking so that this limitation is known and 
the parts that have to be changed identified.

  reply	other threads:[~2018-04-23 13:25 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-18 10:58 [PATCH v4 00/13] soundwire: Add stream support Vinod Koul
2018-04-18 10:58 ` [PATCH v4 01/13] Documentation: soundwire: Add more documentation Vinod Koul
2018-04-18 10:58 ` [PATCH v4 02/13] soundwire: Add support for SoundWire stream management Vinod Koul
2018-04-21 13:02   ` Pierre-Louis Bossart
2018-04-21 16:17     ` Vinod Koul
2018-04-23 13:25       ` Pierre-Louis Bossart [this message]
2018-04-24  9:02         ` Vinod Koul
2018-04-24  9:25       ` Vinod Koul
2018-04-18 10:58 ` [PATCH v4 03/13] soundwire: Add support for port management Vinod Koul
2018-04-18 10:58 ` [PATCH v4 04/13] soundwire: Add Master and Slave port programming Vinod Koul
2018-04-18 10:58 ` [PATCH v4 05/13] soundwire: Add helpers for ports operations Vinod Koul
2018-04-21 13:39   ` Pierre-Louis Bossart
2018-04-21 15:54     ` Vinod Koul
2018-04-21 13:47   ` Pierre-Louis Bossart
2018-04-21 15:53     ` Vinod Koul
2018-04-23 13:27       ` Pierre-Louis Bossart
2018-04-24  9:03         ` Vinod Koul
2018-04-18 10:58 ` [PATCH v4 06/13] soundwire: Add bank switch routine Vinod Koul
2018-04-18 10:59 ` [PATCH v4 07/13] soundwire: Add stream configuration APIs Vinod Koul
2018-04-21 13:56   ` Pierre-Louis Bossart
2018-04-21 16:13     ` Vinod Koul
2018-04-23  3:45       ` Sanyog Kale
2018-04-24  9:09         ` Vinod Koul
2018-04-23 13:30       ` Pierre-Louis Bossart
2018-04-18 10:59 ` [PATCH v4 08/13] ASoC: Add SoundWire stream programming interface Vinod Koul
2018-04-21 13:59   ` Pierre-Louis Bossart
2018-04-21 15:58     ` Vinod Koul
2018-04-23 13:33       ` Pierre-Louis Bossart
2018-04-24  9:06         ` Vinod Koul
2018-04-24 23:40           ` Pierre-Louis Bossart
2018-04-25  2:49             ` Vinod Koul
2018-04-25 15:08               ` Pierre-Louis Bossart
2018-04-18 10:59 ` [PATCH v4 09/13] soundwire: Remove cdns_master_ops Vinod Koul
2018-04-18 10:59 ` [PATCH v4 10/13] soundwire: cdns: Add port routines Vinod Koul
2018-04-18 10:59 ` [PATCH v4 11/13] soundwire: cdns: Add stream routines Vinod Koul
2018-04-18 10:59 ` [PATCH v4 12/13] soundwire: intel: Add stream initialization Vinod Koul
2018-04-18 10:59 ` [PATCH v4 13/13] soundwire: intel: Add audio DAI ops Vinod Koul
2018-04-21 14:08 ` [PATCH v4 00/13] soundwire: Add stream support Pierre-Louis Bossart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f869e5a4-2651-9ee4-aa3a-6f21eaa15c01@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=patches.audio@intel.com \
    --cc=sanyog.r.kale@intel.com \
    --cc=tiwai@suse.de \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox