From: Jack Yu <jack.yu@realtek.com>
To: Mark Brown <broonie@kernel.org>
Cc: "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"lars@metafoo.de" <lars@metafoo.de>,
"Flove(HsinFu)" <flove@realtek.com>,
"Oder Chiou" <oder_chiou@realtek.com>,
"Shuming [范書銘]" <shumingf@realtek.com>,
"Derek [方德義]" <derek.fang@realtek.com>
Subject: RE: [PATCH] ASoC: rt722-sdca: Remove redundant sdca mask
Date: Mon, 26 Jun 2023 01:53:08 +0000 [thread overview]
Message-ID: <f8ca919ab2bf482aa1b55cc7101b5009@realtek.com> (raw)
In-Reply-To: <7e84b2e3-16ad-41c9-a4c5-9938f4ae8289@sirena.org.uk>
> -----Original Message-----
> From: Mark Brown <broonie@kernel.org>
> Sent: Wednesday, June 21, 2023 8:41 PM
> To: Jack Yu <jack.yu@realtek.com>
> Cc: lgirdwood@gmail.com; alsa-devel@alsa-project.org; lars@metafoo.de;
> Flove(HsinFu) <flove@realtek.com>; Oder Chiou <oder_chiou@realtek.com>;
> Shuming [范書銘] <shumingf@realtek.com>; Derek [方德義]
> <derek.fang@realtek.com>
> Subject: Re: [PATCH] ASoC: rt722-sdca: Remove redundant sdca mask
>
> On Wed, Jun 21, 2023 at 04:07:50PM +0800, Jack Yu wrote:
>
> > Remove redundant sdca mask for clear code.
>
> > sdw_write_no_pm(rt722->slave, SDW_SCP_SDCA_INTMASK1,
> > - SDW_SCP_SDCA_INTMASK_SDCA_0 |
> SDW_SCP_SDCA_INTMASK_SDCA_6);
> > + SDW_SCP_SDCA_INTMASK_SDCA_6);
> > sdw_write_no_pm(rt722->slave, SDW_SCP_SDCA_INTMASK2,
> > SDW_SCP_SDCA_INTMASK_SDCA_8);
> > }
>
> Why is this redundant?
Based on internal register settings, this bit won't be used in any use case, so I remove it for clear code.
>
> ------Please consider the environment before printing this e-mail.
next prev parent reply other threads:[~2023-06-26 1:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 8:07 [PATCH] ASoC: rt722-sdca: Remove redundant sdca mask Jack Yu
2023-06-21 12:40 ` Mark Brown
2023-06-26 1:53 ` Jack Yu [this message]
2023-07-12 11:46 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8ca919ab2bf482aa1b55cc7101b5009@realtek.com \
--to=jack.yu@realtek.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=derek.fang@realtek.com \
--cc=flove@realtek.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=shumingf@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox