From mboxrd@z Thu Jan 1 00:00:00 1970 From: Srinivas Kandagatla Subject: Re: [PATCH] ASoC: qdsp6: q6afe-dai: fix a range check in of_q6afe_parse_dai_data() Date: Fri, 13 Jul 2018 16:45:32 +0100 Message-ID: References: <20180713150557.gsx7wrau2l7tg2jq@kili.mountain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by alsa0.perex.cz (Postfix) with ESMTP id 4FE28267727 for ; Fri, 13 Jul 2018 17:45:34 +0200 (CEST) Received: by mail-wm0-f67.google.com with SMTP id s13-v6so4829126wmc.1 for ; Fri, 13 Jul 2018 08:45:34 -0700 (PDT) In-Reply-To: <20180713150557.gsx7wrau2l7tg2jq@kili.mountain> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Dan Carpenter , Patrick Lai Cc: alsa-devel@alsa-project.org, Banajit Goswami , kernel-janitors@vger.kernel.org, Takashi Iwai , Liam Girdwood , Mark Brown , Niklas Cassel List-Id: alsa-devel@alsa-project.org On 13/07/18 16:05, Dan Carpenter wrote: > The main thing is that the data->priv[] array has AFE_PORT_MAX elements > so the > condition should be >=. But we may as well check for negative > values as well just to be safe. > > Fixes: 24c4cbcfac09 ("ASoC: qdsp6: q6afe: Add q6afe dai driver") > Signed-off-by: Dan Carpenter Thanks for the patch, Acked-by: Srinivas Kandagatla > > diff --git a/sound/soc/qcom/qdsp6/q6afe-dai.c b/sound/soc/qcom/qdsp6/q6afe-dai.c > index e7f809e3ee1f..89df25e711c5 100644 > --- a/sound/soc/qcom/qdsp6/q6afe-dai.c > +++ b/sound/soc/qcom/qdsp6/q6afe-dai.c > @@ -1329,7 +1329,7 @@ static void of_q6afe_parse_dai_data(struct device *dev, > int id, i, num_lines; > > ret = of_property_read_u32(node, "reg", &id); > - if (ret || id > AFE_PORT_MAX) { > + if (ret || id < 0 || id >= AFE_PORT_MAX) { > dev_err(dev, "valid dai id not found:%d\n", ret); > continue; > } >