* [PATCH] soundwire: Fix error return code in sdw_compute_port_params
@ 2020-11-25 6:50 Qinglang Miao
2020-11-30 17:35 ` Pierre-Louis Bossart
0 siblings, 1 reply; 2+ messages in thread
From: Qinglang Miao @ 2020-11-25 6:50 UTC (permalink / raw)
To: Vinod Koul, Bard Liao, Pierre-Louis Bossart, Sanyog Kale
Cc: alsa-devel, linux-kernel, Qinglang Miao
Fix to return the error code -EINVAL in sdw_compute_port_params
instead of 0.
Fixes: 9026118f20e2 ("soundwire: Add generic bandwidth allocation algorithm")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
---
drivers/soundwire/generic_bandwidth_allocation.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/soundwire/generic_bandwidth_allocation.c b/drivers/soundwire/generic_bandwidth_allocation.c
index 0bdef38c9..ad857ac62 100644
--- a/drivers/soundwire/generic_bandwidth_allocation.c
+++ b/drivers/soundwire/generic_bandwidth_allocation.c
@@ -283,8 +283,10 @@ static int sdw_compute_port_params(struct sdw_bus *bus)
if (ret < 0)
return ret;
- if (group.count == 0)
+ if (group.count == 0) {
+ ret = -EINVAL;
goto out;
+ }
params = kcalloc(group.count, sizeof(*params), GFP_KERNEL);
if (!params) {
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] soundwire: Fix error return code in sdw_compute_port_params
2020-11-25 6:50 [PATCH] soundwire: Fix error return code in sdw_compute_port_params Qinglang Miao
@ 2020-11-30 17:35 ` Pierre-Louis Bossart
0 siblings, 0 replies; 2+ messages in thread
From: Pierre-Louis Bossart @ 2020-11-30 17:35 UTC (permalink / raw)
To: Qinglang Miao, Vinod Koul, Bard Liao, Sanyog Kale
Cc: alsa-devel, linux-kernel
On 11/25/20 12:50 AM, Qinglang Miao wrote:
> Fix to return the error code -EINVAL in sdw_compute_port_params
> instead of 0.
>
> Fixes: 9026118f20e2 ("soundwire: Add generic bandwidth allocation algorithm")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Thanks for the patch.
The test covers a very unlikely error scenario but nevertheless not a
zero probability so the suggested fix makes sense to me.
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---
> drivers/soundwire/generic_bandwidth_allocation.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soundwire/generic_bandwidth_allocation.c b/drivers/soundwire/generic_bandwidth_allocation.c
> index 0bdef38c9..ad857ac62 100644
> --- a/drivers/soundwire/generic_bandwidth_allocation.c
> +++ b/drivers/soundwire/generic_bandwidth_allocation.c
> @@ -283,8 +283,10 @@ static int sdw_compute_port_params(struct sdw_bus *bus)
> if (ret < 0)
> return ret;
>
> - if (group.count == 0)
> + if (group.count == 0) {
> + ret = -EINVAL;
> goto out;
> + }
>
> params = kcalloc(group.count, sizeof(*params), GFP_KERNEL);
> if (!params) {
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-30 20:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-25 6:50 [PATCH] soundwire: Fix error return code in sdw_compute_port_params Qinglang Miao
2020-11-30 17:35 ` Pierre-Louis Bossart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).