From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 892CFC0015E for ; Fri, 30 Jun 2023 08:36:13 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 982F8868; Fri, 30 Jun 2023 10:35:21 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 982F8868 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1688114171; bh=Pus1VMfpApBsR7VKPJusC6LwqEbuhtA43n4VaiEGISI=; h=Date:Subject:To:CC:References:From:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=Wr1+jXbZvwUImAvikHWz1ol2vfxKf1QPKLSCTqb1/nHAmIwTUpZGefhsH/kiCjUjl yKmE8myr6TmvlfyDygKDveee4sUt+Z3fhBvhAMkr3DuwYFOwtqdcKLMfm1uRAMJblP Evz2Jb0JQLxumymHw/+0QBNPVUqGU7rcAepsM2nk= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9FB56F8053B; Fri, 30 Jun 2023 10:34:40 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 1B6FFF80534; Fri, 30 Jun 2023 10:34:40 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1FF56F80246; Fri, 30 Jun 2023 04:04:24 +0200 (CEST) Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A42DFF80124 for ; Fri, 30 Jun 2023 04:04:14 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A42DFF80124 Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id A848224DBCE; Fri, 30 Jun 2023 10:04:10 +0800 (CST) Received: from EXMBX172.cuchost.com (172.16.6.92) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 30 Jun 2023 10:04:10 +0800 Received: from [192.168.125.93] (183.27.97.206) by EXMBX172.cuchost.com (172.16.6.92) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 30 Jun 2023 10:04:09 +0800 Message-ID: Date: Fri, 30 Jun 2023 10:04:08 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v1 3/5] ASoC: dt-bindings: Add StarFive JH7110 PWM-DAC controller Content-Language: en-US To: Krzysztof Kozlowski , Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Walker Chen" , Xingyu Wu , Emil Renner Berthing CC: , , , References: <20230626110909.38718-1-hal.feng@starfivetech.com> <20230626110909.38718-4-hal.feng@starfivetech.com> From: Hal Feng In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [183.27.97.206] X-ClientProxiedBy: EXCAS062.cuchost.com (172.16.6.22) To EXMBX172.cuchost.com (172.16.6.92) X-YovoleRuleAgent: yovoleflag X-MailFrom: hal.feng@starfivetech.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1 Message-ID-Hash: LI5HBTTSRMMUJC2OMTL7HNLWHO6LU6RY X-Message-ID-Hash: LI5HBTTSRMMUJC2OMTL7HNLWHO6LU6RY X-Mailman-Approved-At: Fri, 30 Jun 2023 08:34:38 +0000 X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 26 Jun 2023 17:36:20 +0200, Krzysztof Kozlowski wrote: > On 26/06/2023 13:09, Hal Feng wrote: >> Add bindings for the PWM-DAC controller on the JH7110 >> RISC-V SoC by StarFive Ltd. >> >> Signed-off-by: Hal Feng >> --- >> .../sound/starfive,jh7110-pwmdac.yaml | 76 +++++++++++++++++++ >> 1 file changed, 76 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/sound/starfive,jh7110-pwmdac.yaml >> >> diff --git a/Documentation/devicetree/bindings/sound/starfive,jh7110-pwmdac.yaml b/Documentation/devicetree/bindings/sound/starfive,jh7110-pwmdac.yaml >> new file mode 100644 >> index 000000000000..91a4213f2bd8 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/sound/starfive,jh7110-pwmdac.yaml >> @@ -0,0 +1,76 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/sound/starfive,jh7110-pwmdac.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: StarFive JH7110 PWM-DAC Controller >> + >> +description: | > > Do not need '|' unless you need to preserve formatting. Got it. Will drop it later. > >> + The PWM-DAC Controller uses PWM square wave generators plus RC filters to >> + form a DAC for audio play in StarFive JH7110 SoC. This audio play controller >> + supports 16 bit audio format, up to 48K sampling frequency , up to left > > No space before , Will fix. > >> + and right dual channels. >> + >> +maintainers: >> + - Hal Feng > > Reviewed-by: Krzysztof Kozlowski Thanks for your review. Best regards, Hal