From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Marian Postevca <posteuca@mutex.one>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Cc: Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
"Chehab, Mauro" <mauro.chehab@intel.com>,
Mario Limonciello <mario.limonciello@amd.com>,
Vijendar Mukunda <Vijendar.Mukunda@amd.com>,
V sujith kumar Reddy <Vsujithkumar.Reddy@amd.com>,
David Yang <yangxiaohua@everest-semi.com>,
syed sabakareem <Syed.SabaKareem@amd.com>
Subject: Re: [RFC] Sound support for Huawei line of AMD laptops using ACP and ES8336 codec
Date: Fri, 6 Jan 2023 19:15:07 -0600 [thread overview]
Message-ID: <fe30d88f-fe03-f77b-7f34-2b8a063214b9@linux.intel.com> (raw)
In-Reply-To: <871qo7fqjp.fsf@mutex.one>
> I have a Huawei Matebook 14 AMD 2021 laptop for which the sound isn't
> supported on Linux. On further investigation in Windows and ACPI tables
> I could determine that this particular SKU has an ES8336 codec connected
> to the CPU ACP module.
> The CPU of my laptop is an AMD Ryzen 5 5500U which seems to be codenamed
> Lucienne and is a derivation of the Renoir family.
> Acording to lspci the ACP is revision 1:
>
> 03:00.5 Multimedia controller [0480]: Advanced Micro Devices, Inc. [AMD] Raven/Raven2/FireFlight/Renoir Audio Processor [1022:15e2] (rev 01)
> Subsystem: Device [1e83:3e4d]
> Kernel driver in use: snd_rn_pci_acp3x
> Kernel modules: snd_pci_acp3x, snd_rn_pci_acp3x, snd_pci_acp5x,
> snd_pci_acp6x, snd_acp_pci, snd_rpl_pci_acp6x,
> snd_sof_amd_renoir
>
> I have written a machine driver for this platform and managed to make
> the sound and internal microphone work. I am looking to integrate this
> support but there are some issues with the current implementation of ACP
> support.
>
> As far as I can tell there are 4 directions I could take to add support:
>
> 1. A standalone machine driver in sound/soc/amd that uses the platform
> drivers from sound/soc/amd/raven/
>
> 2. An embedded driver in sound/soc/amd/acp/acp-legacy-mach.c
>
> 3. A standalone machine driver in sound/soc/amd that uses the platform
> drivers from sound/soc/amd/renoir
>
> 4. Use the SOF infrastructure
The main issue with this codec is the mind-blowing proliferation of
configurations and quirks.
I can't comment on AMD-specific stuff, but would recommend you take a
look at the GitHub PR we've been reviewing to extract as much
information as possible from ACPI _DSM tables (as done by the Windows
driver). see https://github.com/thesofproject/linux/pull/4112 (credits
to Mauro Chehab for fixing and testing on real hardware and David Yang
for providing the DSM information and comments).
next prev parent reply other threads:[~2023-01-07 1:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 18:47 [RFC] Sound support for Huawei line of AMD laptops using ACP and ES8336 codec Marian Postevca
2023-01-07 1:15 ` Pierre-Louis Bossart [this message]
2023-01-07 6:58 ` Reddy, V sujith kumar
2023-01-09 18:21 ` Limonciello, Mario
2023-01-10 12:27 ` Marian Postevca
2023-01-11 9:33 ` Reddy, V sujith kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe30d88f-fe03-f77b-7f34-2b8a063214b9@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=Syed.SabaKareem@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=Vsujithkumar.Reddy@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mauro.chehab@intel.com \
--cc=posteuca@mutex.one \
--cc=tiwai@suse.com \
--cc=yangxiaohua@everest-semi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox