From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68C66C43331 for ; Tue, 12 Nov 2019 10:52:52 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E13BB2084E for ; Tue, 12 Nov 2019 10:52:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="t7N1iWZ1"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="CragUSkc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E13BB2084E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 2FC3B1607; Tue, 12 Nov 2019 11:52:00 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 2FC3B1607 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1573555970; bh=dNnq6GVm3TWpfU1wAouD7zuZxg9vxRS2JVC5jN6UjXU=; h=To:References:From:Date:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=t7N1iWZ1Uivbo7PpjrwiW80babYdz+DH8O6z5gsNmU2ze1VoWh4Y48hrw/2f0o6HZ I1iRf+vpd7eiuYLRMftnHL0iPJQpixo9C2FF97sI4dt61uswbodjMeqXkSg0dPCjfS ugyghwmhY24tFOHdWUr9gipk5Y8Mg23simKWl3Ys= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id BCE11F8044C; Tue, 12 Nov 2019 11:51:59 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id BC649F80483; Tue, 12 Nov 2019 11:51:57 +0100 (CET) Received: from hqemgate16.nvidia.com (hqemgate16.nvidia.com [216.228.121.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C4B22F802E0 for ; Tue, 12 Nov 2019 11:51:54 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C4B22F802E0 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="CragUSkc" Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 12 Nov 2019 02:50:56 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Tue, 12 Nov 2019 02:51:52 -0800 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Tue, 12 Nov 2019 02:51:52 -0800 Received: from [10.21.133.51] (172.20.13.39) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 12 Nov 2019 10:51:50 +0000 To: Kuninori Morimoto References: <87ftj23jph.wl-kuninori.morimoto.gx@renesas.com> <87d0e63joh.wl-kuninori.morimoto.gx@renesas.com> <87sgmu7xhz.wl-kuninori.morimoto.gx@renesas.com> From: Jon Hunter Message-ID: Date: Tue, 12 Nov 2019 10:51:48 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <87sgmu7xhz.wl-kuninori.morimoto.gx@renesas.com> X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1573555856; bh=9U0iekHPqCKCtONtPFuEXlIHBgl069HGxR9z4sqUB0Y=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=CragUSkcOp2rOui25I7KothxQEPbeBZIwYXe91TsOf9rEEWagZbwahyZBZvnRRS2t mFmr6uDg5UAQabd2kOu3xxe1tFHZplSFIB+cURRqx8UkugVUUXgB+XelV2X6MPcXi2 HLsQb/iYVWflJEZ641SVLt0xXptzirWcWpb7aUpURrd8UifH1s02v4oRIA8xEL2jBf B84STsRC5JMN88tHhNws5B6MYTEHpAjVM3NcwWYirxlbGHXd5T2P6BdsI3LQxCAtJW y5AJtHeOsZVx9JRu3cfih2aDCR63JpmF0plY/PMgY02h7Psnnt1Usr4Z14nVewWsA3 kPYLKlXgVIwXA== Cc: linux-tegra , Linux-ALSA , Mark Brown , Pierre-Louis Bossart , Ranjani Sridharan Subject: Re: [alsa-devel] [PATCH v3 02/19] ASoC: soc-core: tidyup soc_init_dai_link() X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 12/11/2019 00:24, Kuninori Morimoto wrote: > > Hi Jon > > Thank you for reporting. > >> I am seeing an audio regression on -next and bisect is pointing to >> this commit. I am seeing the following crash on boot during probe >> deferral of the soundcard ... > > It seems timing bug. > I have a plan to post below patch if my current posting patch are accepted, > but it seems it is necessary immediately. > I believe your issue will be solved by this patch, > but can you please test it ? > I will formally post it with your tested-by if it was OK. > > # It will be more cleanuped in the future, > # but it needs more other cleanup patches... > > -------------------- > Subject: [PATCH] ASoC: soc-core: care card_probed at soc_cleanup_card_resources() > > soc_cleanup_card_resources() will call card->remove(), but it should be > called if card->probe() or card->late_probe() are called. > snd_soc_bind_card() might be error before calling > card->probe() / card->late_probe(). > In that time, card->remove() will be called. > This patch adds card_probed parameter to judge it. > > Signed-off-by: Kuninori Morimoto > --- > sound/soc/soc-core.c | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) Thanks! I can confirm that this works, so ... Tested-by: Jon Hunter Cheers Jon -- nvpublic _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel