From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 174A8C77B75 for ; Mon, 22 May 2023 20:34:49 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id CE8A0208; Mon, 22 May 2023 22:33:57 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz CE8A0208 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1684787687; bh=Nx56cbf63OXaAUSBYAnLL+ze08ugHBspK4d6BmMPYso=; h=Subject:From:To:Cc:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=c5CLJWarjZ56nGnDFq4wtX+XnO9fo2JmdqYUczD+tUwXDigXikcKiKFsEJ1a4VtJT ScUoeELT7YSzKBCRMqdZrgfV6r3e2CbvzN6bAiJ/ClnHAYb1SsfIuR9f6/iCeJznQH yPUmRVBIzLp2rl++K5UYU2LKKgjJhe2VIr64Qnm4= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8E1F8F80552; Mon, 22 May 2023 22:33:29 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 2863EF80542; Mon, 22 May 2023 22:33:29 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3BB07F8024E; Mon, 22 May 2023 22:33:25 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id EAA5EF80086; Mon, 22 May 2023 22:33:19 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz EAA5EF80086 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=gclKp644 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684787602; x=1716323602; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=Nx56cbf63OXaAUSBYAnLL+ze08ugHBspK4d6BmMPYso=; b=gclKp644M68PYC4+1NDuYCSMnvrWyE8MkqlnBRZuYmBs+TE3i/s0Xc+P JNr+AZvuYd49qIfknpsXk1M1mmq/pODGjgm4ZkSSzdTFr9np+8cZFrqiu HTZFfZbB2D9DBDxSqyCHGO4MSttERLnKH2R24NP79pN88yOwWW8EKvTnt WURO4aR3L64Q+Ggin6GZWkqnEcIUF/U8LeLAIAu0HmiHb44MQQCBMGAGG jG2bLpxnd0UjqADSyT/waLvdIDOIno4ygfROQvExkzDWh6/iTjbfQYyGZ oaD/nBb7goRKbQe8AeRK0V1m/XtYeeYdPkcIh4Wm9l+cLTomKV3hYobbx A==; X-IronPort-AV: E=McAfee;i="6600,9927,10718"; a="439389512" X-IronPort-AV: E=Sophos;i="6.00,184,1681196400"; d="scan'208";a="439389512" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2023 13:33:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10718"; a="1033750097" X-IronPort-AV: E=Sophos;i="6.00,184,1681196400"; d="scan'208";a="1033750097" Received: from avelapox-mobl.amr.corp.intel.com ([10.212.71.122]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2023 13:33:16 -0700 Message-ID: Subject: Re: [PATCH -next] ASoC: SOF: ipc4-topology: Fix an unsigned comparison which can never be negative From: Ranjani Sridharan To: Yang Li , perex@perex.cz Cc: tiwai@suse.com, pierre-louis.bossart@linux.intel.com, lgirdwood@gmail.com, peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com, daniel.baluta@nxp.com, kai.vehmanen@linux.intel.com, broonie@kernel.org, sound-open-firmware@alsa-project.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Abaci Robot Date: Mon, 22 May 2023 13:33:16 -0700 In-Reply-To: <20230516081116.71370-1-yang.lee@linux.alibaba.com> References: <20230516081116.71370-1-yang.lee@linux.alibaba.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Message-ID-Hash: UNHLPTG6JO67SSGGHO3VUJERQGXJ3634 X-Message-ID-Hash: UNHLPTG6JO67SSGGHO3VUJERQGXJ3634 X-MailFrom: ranjani.sridharan@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 2023-05-16 at 16:11 +0800, Yang Li wrote: > The return value from the call to sof_ipc4_get_valid_bits() is int. > However, the return value is being assigned to an unsigned > int variable 'out_ref_valid_bits', so making it an int. > > Eliminate the following warning: > ./sound/soc/sof/ipc4-topology.c:1537:6-24: WARNING: Unsigned > expression compared with zero: out_ref_valid_bits < 0 > > Reported-by: Abaci Robot > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4985 > Signed-off-by: Yang Li LGTM, thanks! Reviewed-by: Ranjani Sridharan