From mboxrd@z Thu Jan 1 00:00:00 1970 From: Haojian Zhuang Subject: Re: [PATCH 1/4] pxa: add namespace on ssp Date: Thu, 1 Apr 2010 15:45:03 +0800 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pw0-f51.google.com (mail-pw0-f51.google.com [209.85.160.51]) by alsa0.perex.cz (Postfix) with ESMTP id 4C7F5244AA for ; Thu, 1 Apr 2010 09:45:05 +0200 (CEST) Received: by pwj7 with SMTP id 7so787072pwj.38 for ; Thu, 01 Apr 2010 00:45:03 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Eric Miao Cc: alsa-devel@alsa-project.org, Mark Brown , linux-arm-kernel , Liam Girdwood List-Id: alsa-devel@alsa-project.org On Thu, Apr 1, 2010 at 3:33 PM, Eric Miao wrote: > On Wed, Mar 31, 2010 at 8:46 PM, Haojian Zhuang > wrote: >> From b52a0d2687e82f81d38198cb450b6a39a9e53851 Mon Sep 17 00:00:00 2001 >> From: Haojian Zhuang >> Date: Wed, 31 Mar 2010 15:08:55 -0400 >> Subject: [PATCH] [ARM] pxa: add namespace on ssp >> >> In order to prevent code ambiguous, add namespace on functions in ssp driver. >> > > Haojian, > > This is not necessary, provided that those functions are static already. > Unless this driver is going to support a different SSP, in which case a > separate driver is needed then. > > What's the real motivation behind this? > It's the request from Mark. Both ssp_ and pxa_ssp_ prefix exist in pxa-ssp.c. From the view of naming space, it's not align. Thanks Haojian