From: 김명욱 <mwkim@gaonchips.com>
To: "Bagas Sanjaya" <bagasdotme@gmail.com>, alsa-devel@alsa-project.org
Cc: "Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"Maxim Kochetkov" <fido_max@inbox.ru>,
"Kuninori Morimoto" <kuninori.morimoto.gx@renesas.com>,
"Xingyu Wu" <xingyu.wu@starfivetech.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-kernel@vger.kernel.org, mwkim@gaonchips.com
Subject: RE: Re: [PATCH] ASoC: dwc: fix typo in comment
Date: Tue, 12 Sep 2023 10:23:07 +0900 [thread overview]
Message-ID: <gab64ffbd7bdbafc@gaonchips.com> (raw)
ISR_RXFO means \"Status of Data Overrun interrupt for the RX channel\"
according to the datasheetSo, the comment should be RX, not
TXThanksMyunguk------------Original Message------------Subject : Re: [PATCH]
ASoC: dwc: fix typo in commentDate : 2023-09-11 21:46:05From : Bagas Sanjaya
<bagasdotme@gmailcom>To : Myunguk Kim <mwkim@gaonchipscom>,
alsa-devel@alsa-projectorgCc : Liam Girdwood <lgirdwood@gmailcom>,
Mark Brown <broonie@kernelorg>, Jaroslav Kysela <perex@perexcz>,
Takashi Iwai <tiwai@susecom>, Maxim Kochetkov
<fido_max@inboxru>, Kuninori Morimoto
<kuninorimorimotogx@renesascom>, Xingyu Wu
<xingyuwu@starfivetechcom>, Uwe Kleine-König
<ukleine-koenig@pengutronixde>, linux-kernel@vgerkernelorgOn Mon, Sep
11, 2023 at 03:46:46PM +0900, Myunguk Kim wrote:> This fixes typo in
commentOn what? Can you describe the typofix in more detail?>>
Signed-off-by: Myunguk Kim <mwkim@gaonchipscom>> --->
sound/soc/dwc/dwc-i2sc | 2 +-> 1 file changed, 1 insertion(+), 1
deletion(-)>> diff --git a/sound/soc/dwc/dwc-i2sc
b/sound/soc/dwc/dwc-i2sc> index 71ff894035a445e55e550924 100644> ---
a/sound/soc/dwc/dwc-i2sc> +++ b/sound/soc/dwc/dwc-i2sc> @@ -138,7
+138,7 @@ static irqreturn_t i2s_irq_handler(int irq, void *dev_id)>
irq_valid = true;> }>> - /* Error Handling: TX */> + /* Error
Handling: RX */> if (isr[i] & ISR_RXFO)> {
dev_err_ratelimited(dev->dev, \"RX overrun (ch_id=%d)\\n\", i);>
irq_valid = true;Oh, you mean the code following the comment checks for RXFO
overrunConfused--An old man doll just what I always wanted! - Clara
next reply other threads:[~2023-09-12 10:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 1:23 김명욱 [this message]
2023-09-12 1:34 ` [PATCH] ASoC: dwc: fix typo in comment Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gab64ffbd7bdbafc@gaonchips.com \
--to=mwkim@gaonchips.com \
--cc=alsa-devel@alsa-project.org \
--cc=bagasdotme@gmail.com \
--cc=broonie@kernel.org \
--cc=fido_max@inbox.ru \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=xingyu.wu@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox