alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ALSA: hda: Fix 0 dB for Packard Bell models using Conexant CX20549 (Venice)
@ 2010-04-28 22:07 Daniel Chen
  2010-05-05  8:01 ` Takashi Iwai
  0 siblings, 1 reply; 7+ messages in thread
From: Daniel Chen @ 2010-04-28 22:07 UTC (permalink / raw)
  To: Takashi Iwai, stable; +Cc: alsa-devel

[-- Attachment #1: Type: text/plain, Size: 214 bytes --]

Hi,

Attached is a patch against sound-2.6 master HEAD (also applicable to
2.6.32.12 and 2.6.33.3) that fixes 0 dB for Packard Bell machines
using Conexant CX20549. Without it, sound distorts horribly.

Best,
-Dan

[-- Attachment #2: 0001-ALSA-hda-Fix-0-dB-for-Packard-Bell-models-using-Cone.patch --]
[-- Type: text/x-diff, Size: 1329 bytes --]

From e2109922f4505fe08ef6e24673b4e4a91648fa4e Mon Sep 17 00:00:00 2001
From: Daniel T Chen <crimsun@ubuntu.com>
Date: Wed, 28 Apr 2010 18:00:11 -0400
Subject: [PATCH] ALSA: hda: Fix 0 dB for Packard Bell models using Conexant CX20549 (Venice)

BugLink: https://launchpad.net/bugs/541802

The OR's hardware distorts at PCM 100% because it does not correspond to
0 dB. Fix this in patch_cxt5045() for all Packard Bell models.

Reported-by: Valombre
Cc: <stable@kernel.org>
Signed-off-by: Daniel T Chen <crimsun@ubuntu.com>
---
 sound/pci/hda/patch_conexant.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c
index 509a104..b9644e4 100644
--- a/sound/pci/hda/patch_conexant.c
+++ b/sound/pci/hda/patch_conexant.c
@@ -1196,9 +1196,10 @@ static int patch_cxt5045(struct hda_codec *codec)
 
 	switch (codec->subsystem_id >> 16) {
 	case 0x103c:
+	case 0x1631:
 	case 0x1734:
-		/* HP & Fujitsu-Siemens laptops have really bad sound over 0dB
-		 * on NID 0x17. Fix max PCM level to 0 dB
+		/* HP, Packard Bell, & Fujitsu-Siemens laptops have really bad
+		 * sound over 0dB on NID 0x17. Fix max PCM level to 0 dB
 		 * (originally it has 0x2b steps with 0dB offset 0x14)
 		 */
 		snd_hda_override_amp_caps(codec, 0x17, HDA_INPUT,
-- 
1.7.0.4


[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2010-05-11  6:18 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-28 22:07 [PATCH] ALSA: hda: Fix 0 dB for Packard Bell models using Conexant CX20549 (Venice) Daniel Chen
2010-05-05  8:01 ` Takashi Iwai
2010-05-10  7:15   ` Tim Starling
2010-05-10 10:29     ` Daniel Chen
2010-05-10 12:48       ` Tim Starling
2010-05-10 14:17         ` Daniel Chen
2010-05-11  6:18           ` Tim Starling

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).