From: Mohammad Bahathir Hashim <bahathir@gmail.com>
To: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: hda - apply CS420X erratum fix for CS4207 only
Date: Thu, 3 Mar 2011 14:13:32 +0000 (UTC) [thread overview]
Message-ID: <iko7mc$nvf$1@dough.gmane.org> (raw)
In-Reply-To: s5h8vwwjog5.wl%tiwai@suse.de
I am happy to report, that the patch works on my MacBookPro6,2 with
vanilla Linux 2.6.37.
Arigatou Gozaimasita. :)
Thank you.
On 2011-03-03, Takashi Iwai <tiwai@suse.de> wrote:
> OK, to be sure, try the patch below.
>
>
> thanks,
>
> Takashi
>
> ---
> From: Takashi Iwai <tiwai@suse.de>
> Date: Thu, 3 Mar 2011 14:54:19 +0100
> Subject: [PATCH] ALSA: hda - Don't set to D3 in Cirrus errata init verbs
>
> The errata init verbs for CS42xx codecs contain the verbs to set
> the power-state of SPDIF nodes to D3, which seem to break the SPDIF
> output on some MacBooks. Since this is executed during the power-up
> initialization, we shouldn't turn them down there.
>
> Reported-by: Arun Raghavan <arun.raghavan@collabora.co.uk>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
> sound/pci/hda/patch_cirrus.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/sound/pci/hda/patch_cirrus.c b/sound/pci/hda/patch_cirrus.c
> index a07b031..067982f 100644
> --- a/sound/pci/hda/patch_cirrus.c
> +++ b/sound/pci/hda/patch_cirrus.c
> @@ -1039,9 +1039,11 @@ static struct hda_verb cs_errata_init_verbs[] = {
> {0x11, AC_VERB_SET_PROC_COEF, 0x0008},
> {0x11, AC_VERB_SET_PROC_STATE, 0x00},
>
> +#if 0 /* Don't to set to D3 as we are in power-up sequence */
> {0x07, AC_VERB_SET_POWER_STATE, 0x03}, /* S/PDIF Rx: D3 */
> {0x08, AC_VERB_SET_POWER_STATE, 0x03}, /* S/PDIF Tx: D3 */
> /*{0x01, AC_VERB_SET_POWER_STATE, 0x03},*/ /* AFG: D3 This is already handled */
> +#endif
>
> {} /* terminator */
> };
next prev parent reply other threads:[~2011-03-03 14:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-01 5:06 CS4206 and S/PDIF (again) Arun Raghavan
2011-03-01 5:43 ` Arun Raghavan
2011-03-01 5:43 ` Arun Raghavan
2011-03-02 21:48 ` Arun Raghavan
2011-03-02 21:48 ` [PATCH] ALSA: hda - apply CS420X erratum fix for CS4207 only Arun Raghavan
2011-03-02 22:03 ` Austin, Brian
2011-03-03 4:58 ` Mohammad Bahathir Hashim
2011-03-03 5:27 ` Arun Raghavan
2011-03-03 12:01 ` Takashi Iwai
2011-03-03 12:20 ` Arun Raghavan
2011-03-03 13:58 ` Takashi Iwai
2011-03-03 14:07 ` Arun Raghavan
2011-03-03 14:20 ` Takashi Iwai
2011-03-03 18:49 ` Austin, Brian
2011-03-04 7:26 ` Takashi Iwai
2011-03-03 14:13 ` Mohammad Bahathir Hashim [this message]
2011-03-02 22:02 ` CS4206 and S/PDIF (again) Austin, Brian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='iko7mc$nvf$1@dough.gmane.org' \
--to=bahathir@gmail.com \
--cc=alsa-devel@alsa-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).