From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: [PATCH 1/2] powerpc: add platform registration for ALSA SoC drivers Date: Wed, 28 Apr 2010 11:20:40 -0500 Message-ID: References: <1272314980-23679-1-git-send-email-timur@freescale.com> <1272350168.24542.6.camel@pasglop> <1272355624.3204.52.camel@odin> <4BD74D0C.40303@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-iw0-f185.google.com (mail-iw0-f185.google.com [209.85.223.185]) by alsa0.perex.cz (Postfix) with ESMTP id 88C8A24482 for ; Wed, 28 Apr 2010 18:23:26 +0200 (CEST) Received: by iwn15 with SMTP id 15so3040441iwn.2 for ; Wed, 28 Apr 2010 09:23:24 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Grant Likely Cc: alsa-devel@alsa-project.org, Benjamin Herrenschmidt , kumar.gala@freescale.com, broonie@opensource.wolfsonmicro.com, linuxppc-dev@ozlabs.org, Liam Girdwood List-Id: alsa-devel@alsa-project.org On Wed, Apr 28, 2010 at 8:57 AM, Grant Likely w= rote: > I'm just saying move the registration of the machine device out of > arch/powerpc platform code and into the ssi driver. But the SSI driver is an OF driver, and it gets probed for every SSI node in the device tree. On the 8610, that means being probed twice. But I should only call platform_device_register_simple() once. Are you saying that I should call platform_device_register_simple() from the SSI's driver initialization function, fsl_ssi_init()? > Then you've got a > reasonable place to pass shared data (either the ssi device node or > device instance or name. =A0Whatever you need) to the machine driver. The problem is that the fabric driver needs much more information from the device tree than the SSI driver needs. So if the SSI driver is going to pass that information to the fabric driver via the platform data, it's going to have to know what information the fabric driver needs. Then the SSI driver is not board-independent. -- = Timur Tabi Linux kernel developer at Freescale