From: Thierry Vignaud <tvignaud@mandriva.com>
To: Clemens Ladisch <clemens@ladisch.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [alsa-cvslog] alsa-kernel: cmipci: disable "Modem" control on version 39 or newer chips
Date: Mon, 10 Dec 2007 18:23:56 +0100 [thread overview]
Message-ID: <m23aua79ar.fsf@vador.mandriva.com> (raw)
In-Reply-To: <1197299427.3147.1225765285@webmail.messagingengine.com> (Clemens Ladisch's message of "Mon\, 10 Dec 2007 16\:10\:27 +0100")
"Clemens Ladisch" <clemens@ladisch.de> writes:
> > > description:
> > > cmipci: disable "Modem" control on version 39 or newer chips
> > >
> > > On version 39 or newer chips, we better remove the "Modem" control
> > > because this register bit now mutes the front channels of the
> > > multichannel stream.
> >
> > shouldn't that deserve a comment in the code?
>
> Not in my opinion. The "if (version < 39)" makes clear in which
> version the control is used, and both the old and new bits are
> documented in the respective data sheets.
Still a comment would prevent forcing people do double check the data
sheets in order to understand the code...
prev parent reply other threads:[~2007-12-10 17:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ALOGGER1197288764.96@alsa-project.org>
2007-12-10 13:02 ` [alsa-cvslog] alsa-kernel: cmipci: disable "Modem" control on version 39 or newer chips Thierry Vignaud
2007-12-10 15:10 ` Clemens Ladisch
2007-12-10 17:23 ` Thierry Vignaud [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m23aua79ar.fsf@vador.mandriva.com \
--to=tvignaud@mandriva.com \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox