From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Schwab Subject: [PATCH] sound/ppc/powermac: remove undefined operations Date: Sat, 11 Sep 2010 13:16:41 +0200 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org To: alsa-devel@alsa-project.org Cc: linuxppc-dev@lists.ozlabs.org List-Id: alsa-devel@alsa-project.org Modifying an object twice without an intervening sequence point is undefined. Signed-off-by: Andreas Schwab --- sound/ppc/tumbler.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sound/ppc/tumbler.c b/sound/ppc/tumbler.c index 20afdf9..961d982 100644 --- a/sound/ppc/tumbler.c +++ b/sound/ppc/tumbler.c @@ -785,7 +785,7 @@ static int snapper_set_capture_source(struct pmac_tumbler *mix) if (! mix->i2c.client) return -ENODEV; if (mix->capture_source) - mix->acs = mix->acs |= 2; + mix->acs |= 2; else mix->acs &= ~2; return i2c_smbus_write_byte_data(mix->i2c.client, TAS_REG_ACS, mix->acs); -- 1.7.2.3 -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."