From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06D4AC43463 for ; Mon, 21 Sep 2020 08:29:39 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F6E6206D9 for ; Mon, 21 Sep 2020 08:29:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="vM5b0bC4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F6E6206D9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id EA6B617F0; Mon, 21 Sep 2020 10:28:46 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz EA6B617F0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1600676977; bh=Nx1pAzFY4vm34mJtJyfDdogxGpBmnK2+HD4VuqNqqEo=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=vM5b0bC4OlSkQRqJ383cg/MeDBTZ1fkgj1mHvTN3lRXTh0z52bcpBN2Oh4z/WHEcO u3xbJJ9IEtkHg6bKOzO0zk2eXHEl2nXyyLYiJghRl9YIoRRXn+LXZNnSaFk2/thHmT /CBgyhgEFsfFJmwH3v5zkYZ8IJQuQWWpmXO/52Fw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id AFB0FF8021C; Mon, 21 Sep 2020 10:25:00 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id F1F8CF8028E; Mon, 21 Sep 2020 10:24:58 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1DB3BF8020B for ; Mon, 21 Sep 2020 10:24:51 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1DB3BF8020B X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6010DB288; Mon, 21 Sep 2020 08:25:26 +0000 (UTC) Date: Mon, 21 Sep 2020 10:24:50 +0200 Message-ID: From: Takashi Iwai To: trix@redhat.com Subject: Re: [PATCH] ALSA: asihpi: fix iounmap in error handler In-Reply-To: <20200913165230.17166-1-trix@redhat.com> References: <20200913165230.17166-1-trix@redhat.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, ndesaulniers@google.com, tiwai@suse.com, eblennerhassett@audioscience.com, clang-built-linux@googlegroups.com, natechancellor@gmail.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sun, 13 Sep 2020 18:52:30 +0200, trix@redhat.com wrote: > > From: Tom Rix > > clang static analysis flags this problem > hpioctl.c:513:7: warning: Branch condition evaluates to > a garbage value > if (pci.ap_mem_base[idx]) { > ^~~~~~~~~~~~~~~~~~~~ > > If there is a failure in the middle of the memory space loop, > only some of the memory spaces need to be cleaned up. > > At the error handler, idx holds the number of successful > memory spaces mapped. So rework the handler loop to use the > old idx. > > There is a second problem, the memory space loop conditionally > iomaps()/sets the mem_base so it is necessay to initize pci. > > Fixes: 719f82d3987a ("ALSA: Add support of AudioScience ASI boards") > Signed-off-by: Tom Rix Thanks, applied. Takashi