Re: [PATCH 0/6] ALSA: hda/ca0132: Various cleanups and fixes

[Takashi Iwai <tiwai@suse.de>]

On Sat, 16 Jun 2018 03:56:14 +0200,
Alastair Bridgewater wrote:
> 
> The ca0132 codec support is fairly crufty, and the new R3Di and SBZ
> support hasn't exactly improved that situation.  This patch series
> tries to clean up a small amount of longstanding cruft, reverse some
> behavioral changes to other systems made by the recent R3Di/SBZ
> patches, and make the DMic work properly on the Alienware M17x R4.
> 
> For two of these patches (the QUIRK_ALIENWARE patch and the DMic
> patch), it may be that the correct behavior is the exact OPPOSITE of
> what the patch does as far as quirk testing goes (that is, it should
> apply globally, rather than limited to some specific quirk or set of
> quirks), but I have no way to make such a determination at this time,
> so erring on the side of the status quo ante seems appropriate.
> 
> Alastair Bridgewater (6):
>   ALSA: hda/ca0132: Delete pointless assignments to struct auto_pin_cfg
>     fields
>   ALSA: hda/ca0132: Delete redundant UNSOL event requests
>   ALSA: hda/ca0132: Restore behavior of QUIRK_ALIENWARE
>   ALSA: hda/ca0132: Don't test for QUIRK_NONE
>   ALSA: hda/ca0132: Restore PCM Analog Mic-In2
>   ALSA: hda/ca0132: Fix DMic data rate for Alienware M17x R4

Since these look like reasonable fixes, I applied all six patches as
is now.

If any further fixes are needed, please make on top of these.


thanks,

Takashi