Re: Dell USB audio driver workaround

[Takashi Iwai <tiwai@suse.de>]

On Wed, 06 Apr 2016 08:29:12 +0200,
Kailang wrote:
> 
> Hi Takashi,
> 
> Dell had USB dock.
> Maybe firmware issue, the master volume always keep at 0x57.
> Attach patch will fix it to keep at Max volume.
> 
> Could you help us to update it?

Well, I don't get how this patch works..

> diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c
> index 4f85757..84d9a4e 100644
> --- a/sound/usb/mixer.c
> +++ b/sound/usb/mixer.c
> @@ -846,6 +846,12 @@ static void volume_control_quirks(struct usb_mixer_elem_info *cval,
>  {
>  	struct snd_usb_audio *chip = cval->head.mixer->chip;
>  	switch (chip->usb_id) {
> +	case USB_ID(0x0bda, 0x4014): /* Dell workaround */
> +		if (strstr(kctl->id.name, "Playback Volume") != NULL) {
> +			cval->min = 0x0000;
> +			cval->max = 0x0000;
> +		}
> +		break;

So, this means that this value has to be fixed to 0?
If yes, can't we simply remove this volume instead?


thanks,

Takashi