From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: Regression in Traktor Audio10 driver (snd-usb-audio) mixer flags Date: Tue, 12 Jan 2016 23:17:20 +0100 Message-ID: References: <1451586418.9097.8.camel@mixxx.org> <1452262738.27231.46.camel@legoogs.cam.corp.google.com> <1452457217.18937.9.camel@mixxx.org> <1452633881.10729.31.camel@legoogs.cam.corp.google.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 78238260508 for ; Tue, 12 Jan 2016 23:17:21 +0100 (CET) In-Reply-To: <1452633881.10729.31.camel@legoogs.cam.corp.google.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Owen Williams Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Tue, 12 Jan 2016 22:24:41 +0100, Owen Williams wrote: > > Finally found the bad commit: > SHA da6d276957ea56b9514aa5c8d885edf22f0b3e65 > ALSA: usb-audio: Add resume support for Native Instruments controls Great, thanks for spotting out! > I did upgrade my firmware at some point, perhaps the newer firmware > changed how this works. Happy to test whatever patches against a newer > kernel (I'm on Wily, so 4.2.0-23). Could you try the patch below? Takashi --- diff --git a/sound/usb/mixer_quirks.c b/sound/usb/mixer_quirks.c index 0ce888dceed0..279025650568 100644 --- a/sound/usb/mixer_quirks.c +++ b/sound/usb/mixer_quirks.c @@ -793,7 +793,7 @@ static int snd_nativeinstruments_control_put(struct snd_kcontrol *kcontrol, return 0; kcontrol->private_value &= ~(0xff << 24); - kcontrol->private_value |= newval; + kcontrol->private_value |= (unsigned int)newval << 24; err = snd_ni_update_cur_val(list); return err < 0 ? err : 1; }