Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Masanari Iida <standby24x7@gmail.com>
Cc: perex@perex.cz, linux-kernel@vger.kernel.org,
	alsa-devel@alsa-project.org
Subject: Re: [PATCH] sound: core: Fix format string mismatch in seq_midi.c
Date: Mon, 28 Apr 2014 12:18:57 +0200	[thread overview]
Message-ID: <s5h1twhdaem.wl%tiwai@suse.de> (raw)
In-Reply-To: <1398166925-26412-1-git-send-email-standby24x7@gmail.com>

At Tue, 22 Apr 2014 20:42:05 +0900,
Masanari Iida wrote:
> 
> Fix format string mismatch in snd_seq_midisynth_register_port().
> Argument type of p is unsigned int.
> 
> Signed-off-by: Masanari Iida <standby24x7@gmail.com>

Thanks, applied.


Takashi

> ---
>  sound/core/seq/seq_midi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/core/seq/seq_midi.c b/sound/core/seq/seq_midi.c
> index 3e05c55..a1fd77a 100644
> --- a/sound/core/seq/seq_midi.c
> +++ b/sound/core/seq/seq_midi.c
> @@ -362,13 +362,13 @@ snd_seq_midisynth_register_port(struct snd_seq_device *dev)
>  		if (! port->name[0]) {
>  			if (info->name[0]) {
>  				if (ports > 1)
> -					snprintf(port->name, sizeof(port->name), "%s-%d", info->name, p);
> +					snprintf(port->name, sizeof(port->name), "%s-%u", info->name, p);
>  				else
>  					snprintf(port->name, sizeof(port->name), "%s", info->name);
>  			} else {
>  				/* last resort */
>  				if (ports > 1)
> -					sprintf(port->name, "MIDI %d-%d-%d", card->number, device, p);
> +					sprintf(port->name, "MIDI %d-%d-%u", card->number, device, p);
>  				else
>  					sprintf(port->name, "MIDI %d-%d", card->number, device);
>  			}
> -- 
> 2.0.0.rc0.26.g779792a
> 

      reply	other threads:[~2014-04-28 10:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-22 11:42 [PATCH] sound: core: Fix format string mismatch in seq_midi.c Masanari Iida
2014-04-28 10:18 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h1twhdaem.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=standby24x7@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox